[v2,01/10] dt-bindings: clock: Add syscon support to Actions Semi Owl SoCs

Commit Message

Manivannan Sadhasivam Aug. 1, 2018, 3:39 a.m. UTC

Since the clock and reset management units are sharing the same memory
map, document the clock bindings to support System Controller.

Signed-off-by: Manivannan Sadhasivam <[e-mail]>
---
 .../bindings/clock/actions,owl-cmu.txt        | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

Comments

Rob Herring (Arm) Aug. 7, 2018, 5:48 p.m. UTC | #1

On Wed, Aug 01, 2018 at 09:09:06AM +0530, Manivannan Sadhasivam wrote:
> Since the clock and reset management units are sharing the same memory
> map, document the clock bindings to support System Controller.

This is no reason to add child nodes. The existing node can be both a 
clock and reset provider.

> 
> Signed-off-by: Manivannan Sadhasivam <[e-mail]>
> ---
>  .../bindings/clock/actions,owl-cmu.txt        | 21 +++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

Patch

diff --git a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
index d1e60d297387..649c95fc4582 100644
--- a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
+++ b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
@@ -9,8 +9,6 @@  Required Properties:
 - compatible: should be one of the following,
 	"actions,s900-cmu"
 	"actions,s700-cmu"
-- reg: physical base address of the controller and length of memory mapped
-  region.
 - clocks: Reference to the parent clocks ("hosc", "losc")
 - #clock-cells: should be 1.
 
@@ -21,6 +19,13 @@  All available clocks are defined as preprocessor macros in corresponding
 dt-bindings/clock/actions,s900-cmu.h or actions,s700-cmu.h header and can be
 used in device tree sources.
 
+The CMU registers are part of the system-controller block on Owl SoCs.
+
+Parent node should have the following properties :
+- compatible: "syscon", "simple-mfd"
+- reg: physical base address of the controller and length of memory mapped
+  region.
+
 External clocks:
 
 The hosc clock used as input for the plls is generated outside the SoC. It is
@@ -31,11 +36,15 @@  Actions Semi S900 CMU also requires one more clock:
 
 Example: Clock Management Unit node:
 
-        cmu: clock-controller@e0160000 {
-                compatible = "actions,s900-cmu";
+        sysctrl: system-controller@e0160000 {
+                compatible = "syscon", "simple-mfd";
                 reg = <0x0 0xe0160000 0x0 0x1000>;
-                clocks = <&hosc>, <&losc>;
-                #clock-cells = <1>;
+
+                cmu: clock-controller {
+                        compatible = "actions,s900-cmu";
+                        clocks = <&hosc>, <&losc>;
+                        #clock-cells = <1>;
+                };
         };
 
 Example: UART controller node that consumes clock generated by the clock