From patchwork Fri Sep 7 10:07:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10591981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 78374112B for ; Fri, 7 Sep 2018 10:12:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60F4A2ADED for ; Fri, 7 Sep 2018 10:12:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 554472ADFF; Fri, 7 Sep 2018 10:12:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DC2912ADED for ; Fri, 7 Sep 2018 10:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=k0zCU1Dtxok9bQ+qyYHXkh9wkIMHHtEWwu2W7UNkyG8=; b=bOMQ/V+AYB4DVCIZeBeK/LeKFH BZdXYpPNpqqSiDRq4e1+Fzix5/jkvgTmWLlr3IYKgtv0Ad9GoXuRShuBizrvCRCq+lZAbd3Jai+xi 8QLSzWMimS4wEtxr/lYYTvW9jKekSeNzvEJN+X6ayx4fnJJlV4gh4eSNKsS/nqTwUwKD7errFAmJV me+6oM5ORv+b5B2dnX1f4EWLcHystBT2/nE+oLFk9NTKZ+hXmjsE2VSAHGSrmhBv0ILgmuXJZKZ0+ LSi/ui4afeAjR6tfHzAODdcSaWMeSbGb2nLVevBZ47eAgCWBxxqWB+G6dahznhStZA7GW5KY+3x1h D0lqhoDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fyDkO-0001uu-5l; Fri, 07 Sep 2018 10:12:16 +0000 Received: from mail-wm0-f68.google.com ([74.125.82.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fyDjg-0008Ro-4j for linux-arm-kernel@lists.infradead.org; Fri, 07 Sep 2018 10:11:36 +0000 Received: by mail-wm0-f68.google.com with SMTP id q8-v6so14099397wmq.4 for ; Fri, 07 Sep 2018 03:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=874CbkmyKCyBfTs9WgjHeXXK4p9vYZrCF79UGreNijg=; b=JtGi0E8EtyYudsIFL9qZFkG0FIwpMOaj9jFQI1/hi3wcuWuUVInGn/oVbgZUnC7r+/ ESIx8/2m8bMPfnhf3wfWY4zmhcIytQZMz5Btk9LDDq+fi+OSPsUad73nwbz49USeA0LS b4W85gi6o39gPDZGyXE4lmPycrCUtA/umJTTCXGTUJHcgCmByZ5EcEkPG7j25eIDAwie glIN3eQtm369yj3+FrAucFWz2OF4dFF0q7AoTbnklQD9gT0NsR2cQihAaV9WjAAppBnw c3I7nUdHo/dkCeBh/5Bl8R/Iv/3NoMV+/QtvU/fQ4xWQdfyHmf7xvkMHknvLHgJTpywG dZ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=874CbkmyKCyBfTs9WgjHeXXK4p9vYZrCF79UGreNijg=; b=WCwtIVEPPVfkHSa3S/KPmRzklIFZL2pjOIVX1T7FfnER9XHPkHeGWnG5c524vi1axl RlawtCQ/ToAORYlcg1si6D8egMo9rN1yPHiqabC1eVqhf2CRUDQwMyr3famSryXageKf pJrbxFsxWI1cxlMV4Ej9eacZA4JskaDUJVx1ipT2+RAAtwvBWh4r2O5+pP/vENBna1VQ D1N9MVe06koX/tNJRZNxmOp3DmDTS8N3cfmO82S8WflEksWHJNOq7Ulhqd0ciQm7fqn1 1HcOBD7kdRj+BMLJbW7MgD23fg3BpBDHo3+FhOgIHqxnJ88wQQtFQHupqYj2zJkJgEOZ Od7A== X-Gm-Message-State: APzg51DvHIfU9OXosIi0D5THEr1YqdwihM6w8Cs6DDdU9mQGE108319X ZxXBHpA9hIlQLmxAEhwn7ELmeA== X-Google-Smtp-Source: ANB0Vda6VBe5FobB98uJtZPvt++yeqLqlDh6ifRlvqAGdkP0nvvIpNhCJwPav5nsLR05kFpP5HoT8A== X-Received: by 2002:a1c:2108:: with SMTP id h8-v6mr4519638wmh.108.1536314905081; Fri, 07 Sep 2018 03:08:25 -0700 (PDT) Received: from brgl-bgdev.baylibre.local (AStLambert-681-1-83-232.w90-86.abo.wanadoo.fr. [90.86.25.232]) by smtp.gmail.com with ESMTPSA id 72-v6sm6631619wrb.48.2018.09.07.03.08.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 03:08:24 -0700 (PDT) From: Bartosz Golaszewski To: Srinivas Kandagatla , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Sekhar Nori , Kevin Hilman , David Lechner , Boris Brezillon , Andrew Lunn , Alban Bedel , Maxime Ripard , Chen-Yu Tsai Subject: [PATCH v2 05/16] nvmem: sunxi_sid: use devm_nvmem_register() Date: Fri, 7 Sep 2018 12:07:39 +0200 Message-Id: <20180907100750.14564-6-brgl@bgdev.pl> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180907100750.14564-1-brgl@bgdev.pl> References: <20180907100750.14564-1-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180907_031132_227089_6CA8FCA6 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski Use the resource managed variant of nvmem_register(). Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/sunxi_sid.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index d020f89248fd..0296c23db322 100644 --- a/drivers/nvmem/sunxi_sid.c +++ b/drivers/nvmem/sunxi_sid.c @@ -181,15 +181,13 @@ static int sunxi_sid_probe(struct platform_device *pdev) else econfig.reg_read = sunxi_sid_read; econfig.priv = sid; - nvmem = nvmem_register(&econfig); + nvmem = devm_nvmem_register(dev, &econfig); if (IS_ERR(nvmem)) return PTR_ERR(nvmem); randomness = kzalloc(size, GFP_KERNEL); - if (!randomness) { - ret = -EINVAL; - goto err_unreg_nvmem; - } + if (!randomness) + return PTR_ERR(-EINVAL); for (i = 0; i < size; i++) econfig.reg_read(sid, i, &randomness[i], 1); @@ -200,17 +198,6 @@ static int sunxi_sid_probe(struct platform_device *pdev) platform_set_drvdata(pdev, nvmem); return 0; - -err_unreg_nvmem: - nvmem_unregister(nvmem); - return ret; -} - -static int sunxi_sid_remove(struct platform_device *pdev) -{ - struct nvmem_device *nvmem = platform_get_drvdata(pdev); - - return nvmem_unregister(nvmem); } static const struct sunxi_sid_cfg sun4i_a10_cfg = { @@ -243,7 +230,6 @@ MODULE_DEVICE_TABLE(of, sunxi_sid_of_match); static struct platform_driver sunxi_sid_driver = { .probe = sunxi_sid_probe, - .remove = sunxi_sid_remove, .driver = { .name = "eeprom-sunxi-sid", .of_match_table = sunxi_sid_of_match,