From patchwork Fri Sep 14 14:40:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10600907 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 75DA014BD for ; Fri, 14 Sep 2018 14:58:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B3E62AF17 for ; Fri, 14 Sep 2018 14:58:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AE442AF14; Fri, 14 Sep 2018 14:58:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 273042AF14 for ; Fri, 14 Sep 2018 14:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=C4QHXdks/gNkcPS3RiRiy8MUsDTjJbjX5hGaRdFKoXw=; b=Au4NfWd2DqIbQcI2/myWSTjI9C fHvlhUuuS/3yvzsTbddVEGmgWl/MEATd3FK3iXmzHZtiUAz7wICWBDrbG5qzck6ud9S3av/C5v1TR an23GrIPwdr6j5bXDZ11FLwZi5yrC914THOed9lt8ZHPN00KTAiscc815/ZH9QbOI7T0Wi7X+ikzb cl9CCMIrMxJINxPeHAJMK1YnZbsXTMkUYjLor6vIxstrvoIvxeaNsoPh3kcwgSKfj9ibKaZ4lkk0V 6nLWlrHp9qwpg5fi5WqnnbxZtVfKPuTmYEk/H30GSc0oyJ7+P1DzdO5JTXOFLqOtq8iKQOrjMBaWc 8zCykQnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g0pXe-0003xW-Ew; Fri, 14 Sep 2018 14:57:54 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g0pHL-00011k-Hg for linux-arm-kernel@lists.infradead.org; Fri, 14 Sep 2018 14:41:05 +0000 Received: by mail-wm1-x343.google.com with SMTP id 207-v6so2183271wme.5 for ; Fri, 14 Sep 2018 07:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BVLbSgd1wb/HwG+kDXFY/KlS+ziWt1RndHQUeQC7kyc=; b=isCJL/Wkrqg/c5ZnUFCwrlHeC9e63kQRNS6yYITqXuUTzi9QUeW6m+HdSMO9dQBR+s TxAAc9+P9B+aCEivV821qkKzwY3LqqcpZRYDaz36fhZD4dUvils+SpeAbinPeITPpxdJ sS298vBLKyU1GEdjBAr1twcJsgbnzTvE4HrHAKX6mbZL/pOSv/tgjZQ1xh86H7/e0Q7Z J9+BTfK7432MpILwQKzOoJnSODVAZtSrzDwSkGKnJIpT7LJlS68PAGRsZo6Y/w0qk2kF On2Kexn7IIt0YbK8WzL9AjLxEuCelCqvtFel898oddUyfNCa03lWO90I912KwtLgPa77 AvZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BVLbSgd1wb/HwG+kDXFY/KlS+ziWt1RndHQUeQC7kyc=; b=dar9SG2ml0lqZjDNH8GM4ZAkyNhNSbvu3O/Km0Uswv6hsNSaDIwwPUbDW3EtnIVXbq crw8J7y/kSztzvbUblGatFA2wicbTxZJAhsuTA/O7tkk0BBhWVPywgGeBOb1Z3AVnkvC Lf1Hi1Rmey1E0h2L17WN9LQDNN2c0nRRBB2k3rkNqdg3NjW4fP1TaQ1BeqmDyRJhazR/ AUL2JWAkL8CQ6Mg1qF+cM/LS2YP53dAhEW/0bMoHfDk9JZ+vGEezidGv5Im+O3ojUb/H TqoJuhlCWMcjsuXC95gOWrSLENEudP5/N7OdaFdrvgBC5HhoZvBKvWyZ/Y8YChXNGy/I akEQ== X-Gm-Message-State: APzg51BFrGMIyc09480QDv15KMA9DbJCnO6HKs3iOaVRWVTTChRftN4T VfgmUUAH9krnSIS8s/p3XM2tuw== X-Google-Smtp-Source: ANB0VdZVGm4cyztOffbnujLBEDL5C92pYxxkPPUE6lJlaTWeO+l+BV1X/QAp3WYc0wZ4Abd5iZ/s0A== X-Received: by 2002:a7b:c10c:: with SMTP id w12-v6mr2655589wmi.132.1536936052981; Fri, 14 Sep 2018 07:40:52 -0700 (PDT) Received: from brgl-bgdev.home ([2a01:cb1d:af:5b00:e837:b8d5:48c1:571b]) by smtp.gmail.com with ESMTPSA id v46-v6sm10313526wrc.63.2018.09.14.07.40.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Sep 2018 07:40:52 -0700 (PDT) From: Bartosz Golaszewski To: Srinivas Kandagatla , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Sekhar Nori , Kevin Hilman , David Lechner , Boris Brezillon , Andrew Lunn , Alban Bedel , Maxime Ripard , Chen-Yu Tsai Subject: [PATCH v4 22/22] nvmem: use octal permissions instead of constants Date: Fri, 14 Sep 2018 16:40:11 +0200 Message-Id: <20180914144011.27614-23-brgl@bgdev.pl> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180914144011.27614-1-brgl@bgdev.pl> References: <20180914144011.27614-1-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180914_074103_648593_9A2AD149 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski Checkpatch emits a warning when using symbolic permissions. Use octal permissions instead. Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index e44a1860a2b3..ad1227df1984 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -154,7 +154,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, static struct bin_attribute bin_attr_rw_nvmem = { .attr = { .name = "nvmem", - .mode = S_IWUSR | S_IRUGO, + .mode = 0644, }, .read = bin_attr_nvmem_read, .write = bin_attr_nvmem_write, @@ -178,7 +178,7 @@ static const struct attribute_group *nvmem_rw_dev_groups[] = { static struct bin_attribute bin_attr_ro_nvmem = { .attr = { .name = "nvmem", - .mode = S_IRUGO, + .mode = 0444, }, .read = bin_attr_nvmem_read, }; @@ -201,7 +201,7 @@ static const struct attribute_group *nvmem_ro_dev_groups[] = { static struct bin_attribute bin_attr_rw_root_nvmem = { .attr = { .name = "nvmem", - .mode = S_IWUSR | S_IRUSR, + .mode = 0600, }, .read = bin_attr_nvmem_read, .write = bin_attr_nvmem_write, @@ -225,7 +225,7 @@ static const struct attribute_group *nvmem_rw_root_dev_groups[] = { static struct bin_attribute bin_attr_ro_root_nvmem = { .attr = { .name = "nvmem", - .mode = S_IRUSR, + .mode = 0400, }, .read = bin_attr_nvmem_read, };