| Message ID | 20180926130458.2406549-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: omap1: add nand_chip declaration | expand |
Hi Arnd, Arnd Bergmann <arnd@arndb.de> wrote on Wed, 26 Sep 2018 15:04:39 +0200: > The platform_nand_data structure definition is required for ixdp425 > but has now moved to a new header file: > > arch/arm/mach-ixp4xx/ixdp425-setup.c:98:15: error: variable 'ixdp425_flash_nand_data' has initializer but incomplete type > static struct platform_nand_data ixdp425_flash_nand_data = { > ^~~~~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/ixdp425-setup.c:99:3: error: 'struct platform_nand_data' has no member named 'chip' > > Fixes: 19cf5dfa3a31 ("mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
Arnd Bergmann <arnd@arndb.de> writes: > The platform_nand_data structure definition is required for ixdp425 > but has now moved to a new header file: > > arch/arm/mach-ixp4xx/ixdp425-setup.c:98:15: error: variable 'ixdp425_flash_nand_data' has initializer but incomplete type > static struct platform_nand_data ixdp425_flash_nand_data = { > ^~~~~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/ixdp425-setup.c:99:3: error: 'struct platform_nand_data' has no member named 'chip' > > Fixes: 19cf5dfa3a31 ("mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-ixp4xx/ixdp425-setup.c | 1 + Right. Acked-by: Krzysztof Halasa <khalasa@piap.pl>
Hi Arnd, Arnd Bergmann <arnd@arndb.de> wrote on Wed, 26 Sep 2018 15:04:39 +0200: > The platform_nand_data structure definition is required for ixdp425 > but has now moved to a new header file: > > arch/arm/mach-ixp4xx/ixdp425-setup.c:98:15: error: variable 'ixdp425_flash_nand_data' has initializer but incomplete type > static struct platform_nand_data ixdp425_flash_nand_data = { > ^~~~~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/ixdp425-setup.c:99:3: error: 'struct platform_nand_data' has no member named 'chip' > > Fixes: 19cf5dfa3a31 ("mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Sorry for the delay, squashed in nand/next with the commit introducing the regression. Thanks, Miquèl
diff --git a/arch/arm/mach-ixp4xx/ixdp425-setup.c b/arch/arm/mach-ixp4xx/ixdp425-setup.c index 797e7edc7124..57d7df79d838 100644 --- a/arch/arm/mach-ixp4xx/ixdp425-setup.c +++ b/arch/arm/mach-ixp4xx/ixdp425-setup.c @@ -20,6 +20,7 @@ #include <linux/mtd/mtd.h> #include <linux/mtd/rawnand.h> #include <linux/mtd/partitions.h> +#include <linux/mtd/platnand.h> #include <linux/delay.h> #include <linux/gpio.h> #include <asm/types.h>
The platform_nand_data structure definition is required for ixdp425 but has now moved to a new header file: arch/arm/mach-ixp4xx/ixdp425-setup.c:98:15: error: variable 'ixdp425_flash_nand_data' has initializer but incomplete type static struct platform_nand_data ixdp425_flash_nand_data = { ^~~~~~~~~~~~~~~~~~ arch/arm/mach-ixp4xx/ixdp425-setup.c:99:3: error: 'struct platform_nand_data' has no member named 'chip' Fixes: 19cf5dfa3a31 ("mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-ixp4xx/ixdp425-setup.c | 1 + 1 file changed, 1 insertion(+)