From patchwork Wed Sep 26 19:38:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10616679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EFEC9913 for ; Wed, 26 Sep 2018 19:40:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBEF62B6A6 for ; Wed, 26 Sep 2018 19:40:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CF9D62B6BA; Wed, 26 Sep 2018 19:40:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 22A6D2B6A6 for ; Wed, 26 Sep 2018 19:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=xCBJa+Ozi4ReV2WXaE+VcpNXhHp9hQIFOA67jgbzRGU=; b=cq5 nuBpXc+Wsm7YPm6q5vjBXWBya7oJOQi6Prv0BJNb61306lmNwh3Idxslz89TqpA0ytxR5RKgRj1j6 m0NQCJTdSS8YIBFrU2YkbnYh6qtoDqlGIdHGHqkeQnFQze9UQaZJE3CASyTGBYs20eeSA8yBXtmbF Txecn6WsEGLO+YNCMU0gicvsdSHYXOBrTffVJ0E6r59E/FGuojc87JrgMD7zKaydhusnLObOnjgEu fb/7M4XNB8FF/fOHoXhhdagubYwEmyU/XyHa8DyRQpV1ttXKN4QK9wCdQpUPCQdjt6GKzULPR8Ak7 S28piHEZ6OIayJ2ad03EIq5/cGRLM2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5Ffh-00062a-QF; Wed, 26 Sep 2018 19:40:29 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5FeG-0005zG-Sz; Wed, 26 Sep 2018 19:39:02 +0000 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MFshF-1fyvRK0r9z-00HNTr; Wed, 26 Sep 2018 21:38:21 +0200 From: Arnd Bergmann To: Sean Wang , Linus Walleij , Matthias Brugger Subject: [PATCH] pinctrl: mediatek: mark dummy helpers as 'static inline' Date: Wed, 26 Sep 2018 21:38:09 +0200 Message-Id: <20180926193818.2481220-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:U4TWxtICXljj/5j09tCKrv67Z85xP2cxpkeXlSTGbXjqP+u0d6H fcKJlK8i2GgNBaNfDoKQBEfypHR6YfYAdicoobLlFxO7rJDvex+E8KNqgykzskywRnt71HJ l01N/s/DiJPbXj0xTUhSZLtRDVAKTmC3UAmB7jB6O0zhPHH8Q9jtqDGBpVv1Xwy+4vqfHDT ZsRhx5sEZLuzGY6YSJLcA== X-UI-Out-Filterresults: notjunk:1;V01:K0:cwENl99UqBw=:yFNVMb058SugpmC5fH4kv9 tZaTD8m93KP9FfaaAJ98TFP7f8ExZXdWxxr+CYmOtDyJGin9U+E8RYShA0DZljB8qKB+7w2ID NsKqStQYNFXbF9RP/ez5/uDIPzIyfhpQwTGOzk7rcZNAHMyS+lqsqwpeGtwkdQkM0k3vbVua+ MBZarDGcT30qB0KqDASIlSohHWI5hpIy0TIUw3G3gXsO49nsVAFcfMWaBtCRu+jb50w7PlUPf OIolECIWbsaENcQ2mioJ7pKpH8XY17ck0BcipXFPNaBCfiTH6VBh8uHtHOI4extawgo4RuxfL ixHs7ISoIawJdgEvAf4macFjli3pd42e9DeaOBGHkPUFClXoEY1njetHL07Q26xuJaad3UTS3 8UYChwH30yYj72Lx/F0KnW/kGuOx7yrmR4Tse+IekFNjsQkkZ9m7V1+K+8Pr8yNI4bmWSc8gV WaqOdsNdgCt5Yi+9F41JsBvhcxysjs9j4rxIGamFb7vSC0HJNx8FL7/I0SygZsK8VS/RYmgOs O301Gr6RkiHEptS9iolmpmO8n38xBNRJBIUlPKMo4WJ2C0SKIyfQNMTcyCqyRXV2ipkMNdh40 i9UI+nC4/3XsqR3LtdPuNDteBrST0RVoG+H+odW16xflu1jvzyaf/qSOIMzIp8Z+zr/jhfKlp fzf2dLAxuIOOM9J1kYuycHyDTFgVecMaohDPEdZACjy31oUIvbNYygHEIOFUQ4HfSoS4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180926_123901_241848_0112C845 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP mtk_eint_set_debounce and mtk_eint_find_irq are defined as stub functions in a header file, but without marking them as 'static inline', we get a copy for each file that includes the header: drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.o: In function `mtk_eint_set_debounce': pinctrl-mtk-common-v2.c:(.text+0x134): multiple definition of `mtk_eint_set_debounce' drivers/pinctrl/mediatek/pinctrl-moore.o:pinctrl-moore.c:(.text+0x7d0): first defined here drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.o: In function `mtk_eint_find_irq': pinctrl-mtk-common-v2.c:(.text+0x13c): multiple definition of `mtk_eint_find_irq' Fixes: e46df235b4e6 ("pinctrl: mediatek: refactor EINT related code for all MediaTek pinctrl can fit") Signed-off-by: Arnd Bergmann Acked-by: Sean Wang --- drivers/pinctrl/mediatek/mtk-eint.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mediatek/mtk-eint.h b/drivers/pinctrl/mediatek/mtk-eint.h index c286a9b940f2..48468d0fae68 100644 --- a/drivers/pinctrl/mediatek/mtk-eint.h +++ b/drivers/pinctrl/mediatek/mtk-eint.h @@ -92,13 +92,13 @@ static inline int mtk_eint_do_resume(struct mtk_eint *eint) return -EOPNOTSUPP; } -int mtk_eint_set_debounce(struct mtk_eint *eint, unsigned long eint_n, +static inline int mtk_eint_set_debounce(struct mtk_eint *eint, unsigned long eint_n, unsigned int debounce) { return -EOPNOTSUPP; } -int mtk_eint_find_irq(struct mtk_eint *eint, unsigned long eint_n) +static inline int mtk_eint_find_irq(struct mtk_eint *eint, unsigned long eint_n) { return -EOPNOTSUPP; }