From patchwork Wed Oct 17 14:03:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 10645691 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 28DD71057 for ; Wed, 17 Oct 2018 14:04:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 135EC2B13B for ; Wed, 17 Oct 2018 14:04:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 078C92B158; Wed, 17 Oct 2018 14:04:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ECFFD2B13B for ; Wed, 17 Oct 2018 14:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M0pn9abnz7cY9yDwDYa+J7u3+Esfdt9gKO24KFuB+QM=; b=ZhHDzmuIN4ui9J nI4d09T2+FV9DstXuhjYw8cCCb1O3dR+L9107SpCDycDg1uSQDA+zJmgGU1uloQyOUBuiplcd61KR 020Wc7nHvSZ9TgXgcbKvMWfDscz/OGVQEmDVFqpOslKEIRyk/Pk0d3OwpFHJ0Q09P6vHA0EQVbXgu 3WXSx2EmelBfCdUJG6x3bR8bAAeXba2vhOXPOCbjOS3hNasYF/b9O3SubAC0E5KKY7PLCa8mSlfxW /rr41TTdDecKTy2ule2hOcTFPQhJ8cthx+h+ff9lckTf+wcyI1kyCBBNxdJIMriYfKcWtx2jFQtyG JZox+ukSl6QbwVOuzv4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCmQo-0007gt-It; Wed, 17 Oct 2018 14:04:14 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCmQL-0007R3-0x for linux-arm-kernel@lists.infradead.org; Wed, 17 Oct 2018 14:03:56 +0000 Received: by mail-lf1-x142.google.com with SMTP id n26-v6so1207542lfl.1 for ; Wed, 17 Oct 2018 07:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FYD5OgbslaSN2IMFW2M3a1vvfCw0/W1XvkhV0Wehs50=; b=O4IetBcJP4FShQawjKO6gD6lkk5p+jXVhrvJjpxnlEbgSrp6i/UyAMQVXvVlNYshZa EguhuuvDlRAJCOPsDRf0dztrSz2A7vIkoDmMjSp2yUrhMgf9aU7SipV+RsEUNZozm+Hj f8KkWtM8gK//jIKmnWh8upOytH4pJ5PUNe+3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FYD5OgbslaSN2IMFW2M3a1vvfCw0/W1XvkhV0Wehs50=; b=O6ZqjPDW4HtTWGFdNNgBL3IsJepgvimsYT/BoacKgYJPgPwCLCX40UXI+yRXtJyvrJ TwiwC7M0sPy5NW0opQ983tYy1XtH/r/ecTdYYZzvAy5m5CwV5ILtGkUw+DD25jhAr8zz puwRZ4BH5ivBZrjxzGqDNNfE79bxVVjt3YAdVH7lFN8IRu6POOyHveKBqToPYN628AST mLvGm8ARnU8cEw7Kz/4sk7DDhDEXej4f/xSDzKVSZrrbt77bRpiHoRWV11TAsasbmAk8 wMEpEp+hy/+friIt+Z5Ht9xA+zXA0QWq1gAGtLd5C0YP4h1SpZgE4Gf8Gp+qzVwBLmsx CCXw== X-Gm-Message-State: ABuFfojc81qAAzSLW13/6Dt/RN9g9uYvv+DxLR/vQtNs6gWVfIv8sjrP n44HIw9FivQbmgan52ed9edrCw== X-Google-Smtp-Source: ACcGV63oXudWyvUqX71gA0NBw/l59Ng2ymIskw4Cf2YDo5cX7uwVlXjZXnw2R1nnePcu2vSpH/RvvQ== X-Received: by 2002:a19:c189:: with SMTP id r131-v6mr14739969lff.59.1539785012982; Wed, 17 Oct 2018 07:03:32 -0700 (PDT) Received: from localhost (c-732171d5.07-21-73746f28.bbcust.telenor.se. [213.113.33.115]) by smtp.gmail.com with ESMTPSA id o101-v6sm3931820lfg.53.2018.10.17.07.03.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Oct 2018 07:03:32 -0700 (PDT) From: Anders Roxell To: linux@armlinux.org.uk, gregkh@linuxfoundation.org, akpm@linux-foundation.org Subject: [PATCH 2/2] writeback: don't decrement wb->refcnt if !wb->bdi Date: Wed, 17 Oct 2018 16:03:11 +0200 Message-Id: <20181017140311.28679-2-anders.roxell@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181017140311.28679-1-anders.roxell@linaro.org> References: <20181017140311.28679-1-anders.roxell@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181017_070345_109892_0785DB53 X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anders Roxell , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-serial@vger.kernel.org, tj@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE devtmpfs gets killed because we try to remove a file and decrement the wb reference count before the noop_backing_device_info gets initialized. Since arch_initcall(pl011_init) came before subsys_initcall(default_bdi_init), devtmpfs' handle_remove() crashes because the reference count is a NULL pointer only because bdi->wb hasn't been initialized yet. [ 0.332075] Serial: AMBA PL011 UART driver [ 0.485276] 9000000.pl011: ttyAMA0 at MMIO 0x9000000 (irq = 39, base_baud = 0) is a PL011 rev1 [ 0.502382] console [ttyAMA0] enabled [ 0.515710] Unable to handle kernel paging request at virtual address 0000800074c12000 [ 0.516053] Mem abort info: [ 0.516222] ESR = 0x96000004 [ 0.516417] Exception class = DABT (current EL), IL = 32 bits [ 0.516641] SET = 0, FnV = 0 [ 0.516826] EA = 0, S1PTW = 0 [ 0.516984] Data abort info: [ 0.517149] ISV = 0, ISS = 0x00000004 [ 0.517339] CM = 0, WnR = 0 [ 0.517553] [0000800074c12000] user address but active_mm is swapper [ 0.517928] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 0.518305] Modules linked in: [ 0.518839] CPU: 0 PID: 13 Comm: kdevtmpfs Not tainted 4.19.0-rc5-next-20180928-00002-g2ba39ab0cd01-dirty #82 [ 0.519307] Hardware name: linux,dummy-virt (DT) [ 0.519681] pstate: 80000005 (Nzcv daif -PAN -UAO) [ 0.519959] pc : __destroy_inode+0x94/0x2a8 [ 0.520212] lr : __destroy_inode+0x78/0x2a8 [ 0.520401] sp : ffff0000098c3b20 [ 0.520590] x29: ffff0000098c3b20 x28: 00000000087a3714 [ 0.520904] x27: 0000000000002000 x26: 0000000000002000 [ 0.521179] x25: ffff000009583000 x24: 0000000000000000 [ 0.521467] x23: ffff80007bb52000 x22: ffff80007bbaa7c0 [ 0.521737] x21: ffff0000093f9338 x20: 0000000000000000 [ 0.522033] x19: ffff80007bbb05d8 x18: 0000000000000400 [ 0.522376] x17: 0000000000000000 x16: 0000000000000000 [ 0.522727] x15: 0000000000000400 x14: 0000000000000400 [ 0.523068] x13: 0000000000000001 x12: 0000000000000001 [ 0.523421] x11: 0000000000000000 x10: 0000000000000970 [ 0.523749] x9 : ffff0000098c3a60 x8 : ffff80007bbab190 [ 0.524017] x7 : ffff80007bbaa880 x6 : 0000000000000c88 [ 0.524305] x5 : ffff0000093d96c8 x4 : 61c8864680b583eb [ 0.524567] x3 : ffff0000093d6180 x2 : ffffffffffffffff [ 0.524872] x1 : 0000800074c12000 x0 : 0000800074c12000 [ 0.525207] Process kdevtmpfs (pid: 13, stack limit = 0x(____ptrval____)) [ 0.525529] Call trace: [ 0.525806] __destroy_inode+0x94/0x2a8 [ 0.526108] destroy_inode+0x34/0x88 [ 0.526370] evict+0x144/0x1c8 [ 0.526636] iput+0x184/0x230 [ 0.526871] dentry_unlink_inode+0x118/0x130 [ 0.527152] d_delete+0xd8/0xe0 [ 0.527420] vfs_unlink+0x240/0x270 [ 0.527665] handle_remove+0x1d8/0x330 [ 0.527875] devtmpfsd+0x138/0x1c8 [ 0.528085] kthread+0x14c/0x158 [ 0.528291] ret_from_fork+0x10/0x18 [ 0.528720] Code: 92800002 aa1403e0 d538d081 8b010000 (c85f7c04) [ 0.529367] ---[ end trace 5a3dee47727f877c ]--- Rework so that wb_put have an extra check if wb->bdi before decrement wb->refcnt and also add a WARN_ON to get a warning if it happens again in other drivers. Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") Cc: Arnd Bergmann Co-developed-by: Arnd Bergmann Signed-off-by: Anders Roxell Signed-off-by: Arnd, please. --- include/linux/backing-dev-defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h index 9a6bc0951cfa..20721550d32a 100644 --- a/include/linux/backing-dev-defs.h +++ b/include/linux/backing-dev-defs.h @@ -258,7 +258,7 @@ static inline void wb_get(struct bdi_writeback *wb) */ static inline void wb_put(struct bdi_writeback *wb) { - if (wb != &wb->bdi->wb) + if (!WARN_ON(!wb->bdi) && wb != &wb->bdi->wb) percpu_ref_put(&wb->refcnt); }