From patchwork Thu Oct 25 14:18:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 10655895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E66714BB for ; Thu, 25 Oct 2018 14:31:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B6422BBFF for ; Thu, 25 Oct 2018 14:31:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8949A2BC5A; Thu, 25 Oct 2018 14:31:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F30752BC8B for ; Thu, 25 Oct 2018 14:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VmX20NeEFdtaEIJ5GpBfHEGhBTx+GZIZCmOZuU1wyWk=; b=crM9O1lYNwbdUpUZ9NyfLgZZzz YNmMG4URY528KuXjLU8BHqAL5LKN3P7wX/Tdyw9D3M6D1JtOcDzpqIalT4LTp1h3wb/+Eb2v3HFac DsQMwQMthgX/TlPirOeOAb/AplBA4GlbTeiA1lkR8Bed2sPgY+b0EqmjIIglc9YRdnUj3HIFUIDmM XJyGY69uv1f5JKlKTPtdn2y/0Sx8KSJVRHKHjj4v3bRS7iRlqvU4AdO6EXV0XmM8Qmde2VYzhsvlD On2E3uel6291tNcJ6rwTSvHXmNTUpuZNI1ZEnVqYvfhNW4N3yKkHx8ODuHNnUW1uaexPnu3slv12P d9oLUFTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFgfi-0001HM-Ig; Thu, 25 Oct 2018 14:31:38 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFgVX-0004ZB-NF for linux-arm-kernel@bombadil.infradead.org; Thu, 25 Oct 2018 14:21:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=q5Z5GHiuDPZ8V3x/stra/sJnKeL/m52L6+iq1RhPbk4=; b=g3AgZ9tWsknMR5NRl8ZUovdqH XqpQHh9k6Y+ISig6p9OJeVwJ1DOZISNpDXeAtxn1ghtG1yjnvOmYa1p9xvh4Z71f8sEA5255aeJi+ 4Jye95+LZYM7XBgegDUN5O8kkXBq4T3gIiNCiJnj1V6ad97PpFsKUwByQYHaI1XB8eUU3KMD3V6Vl 6vDNJsc+DP0ptUlT7nQQ3MBD57Wh9tr7Gm1BUj0agrjdVAi3t3mfpprOE/ON0ZEaiO4sRcTIyEKw4 J9CDzAjRWT5OsYbjHynRO2DYy3yJuLXUJsxCvT1kTeCQWc5byKXefjRy0n9r3zl4enckmzyl0doWf bROzuzgFA==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFgVT-0000Iz-4p for linux-arm-kernel@lists.infradead.org; Thu, 25 Oct 2018 14:21:05 +0000 Received: from sasha-vm.mshome.net (unknown [167.98.65.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B38B42086D; Thu, 25 Oct 2018 14:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540477251; bh=cbSHfCGldFQfgA6G4YXr5JHdOoC7UICgr8ILQAwk9C8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mj5ksQx7R8mS/OUUGpqMTZSg7Lyw5sqYa0pUMRIBTPo3xnM0WFCqMAWD7slkjC4cl 5H7RwJ02CA2fkOm//zLO1Ud4LURpAL0n3vU2DaZfUgGponMeUh6CDzPfc9uj7Y+l75 nYu46Rb7oB+CAzmbGBvvH5IUixrAcmLlDBrsDdsk= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 3.18 77/98] clocksource/exynos_mct: Clear interrupt when cpu is shut down Date: Thu, 25 Oct 2018 10:18:32 -0400 Message-Id: <20181025141853.214051-77-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181025141853.214051-1-sashal@kernel.org> References: <20181025141853.214051-1-sashal@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181025_152103_317197_CA15582F X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , javier@osg.samsung.com, daniel.lezcano@linaro.org, krzk@kernel.org, cw00.choi@samsung.com, kgene@kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Joonyoung Shim [ Upstream commit bc7c36eedb0c7004aa06c2afc3c5385adada8fa3 ] When a CPU goes offline a potentially pending timer interrupt is not cleared. When the CPU comes online again then the pending interrupt is delivered before the per cpu clockevent device is initialized. As a consequence the tick interrupt handler dereferences a NULL pointer. [ 51.251378] Unable to handle kernel NULL pointer dereference at virtual address 00000040 [ 51.289348] task: ee942d00 task.stack: ee960000 [ 51.293861] PC is at tick_periodic+0x38/0xb0 [ 51.298102] LR is at tick_handle_periodic+0x1c/0x90 Clear the pending interrupt in the cpu dying path. Fixes: 56a94f13919c ("clocksource: exynos_mct: Avoid blocking calls in the cpu hotplug notifier") Reported-by: Seung-Woo Kim Signed-off-by: Joonyoung Shim Cc: linux-samsung-soc@vger.kernel.org Cc: cw00.choi@samsung.com Cc: daniel.lezcano@linaro.org Cc: stable@vger.kernel.org Cc: javier@osg.samsung.com Cc: kgene@kernel.org Cc: krzk@kernel.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1484628876-22065-1-git-send-email-jy0922.shim@samsung.com Signed-off-by: Thomas Gleixner Signed-off-by: Sasha Levin --- drivers/clocksource/exynos_mct.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c index c844616028d2..714f9a767b17 100644 --- a/drivers/clocksource/exynos_mct.c +++ b/drivers/clocksource/exynos_mct.c @@ -487,6 +487,7 @@ static void exynos4_local_timer_stop(struct clock_event_device *evt) if (mct_int_type == MCT_INT_SPI) { if (evt->irq != -1) disable_irq_nosync(evt->irq); + exynos4_mct_write(0x1, mevt->base + MCT_L_INT_CSTAT_OFFSET); } else { disable_percpu_irq(mct_irqs[MCT_L0_IRQ]); }