diff mbox series

[RFC,15/18] stagning: vchiq_core: fix logic redundancy in parse_open

Message ID 20181026134813.7775-16-nsaenzjulienne@suse.de
State RFC
Headers show
Series staging: vchiq: remove dead code & misc fixes | expand

Commit Message

Nicolas Saenz Julienne Oct. 26, 2018, 1:48 p.m. UTC
We update sync to reflect that the firmware version is compatible with
that option. We don't need to check both of them again further down the
code.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Stefan Wahren Oct. 28, 2018, 8:58 p.m. UTC | #1
> Nicolas Saenz Julienne <nsaenzjulienne@suse.de> hat am 26. Oktober 2018 um 15:48 geschrieben:
> 
> 
> We update sync to reflect that the firmware version is compatible with
> that option. We don't need to check both of them again further down the
> code.

please fix the typo in the subject s/stagning/staging/ for this patch and patch #4
diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 0c37b7032857..a5664a44258e 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -1462,9 +1462,7 @@  parse_open(VCHIQ_STATE_T *state, VCHIQ_HEADER_T *header)
 					service->sync = 0;
 
 				/* Acknowledge the OPEN */
-				if (service->sync &&
-				    (state->version_common >=
-				     VCHIQ_VERSION_SYNCHRONOUS_MODE)) {
+				if (service->sync) {
 					if (queue_message_sync(
 						state,
 						NULL,