Message ID | 20181104182705.18047-24-jernej.skrabec@siol.net (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C19313B5 for <patchwork-linux-arm@patchwork.kernel.org>; Sun, 4 Nov 2018 18:48:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CC8929778 for <patchwork-linux-arm@patchwork.kernel.org>; Sun, 4 Nov 2018 18:48:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 309D02977B; Sun, 4 Nov 2018 18:48:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D305B29778 for <patchwork-linux-arm@patchwork.kernel.org>; Sun, 4 Nov 2018 18:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6SZjMLRjve+nJBubnIlejZcyEPQKEd2b/+29np1JK3g=; b=fY1DUwefsYOcX8 J6w5xs7Wg7o8grPgcKsHL0m+9WKHwyu7o4kPDh04odTQACnk3D9Jnf2acSWYD9P8j3n0el/rlHMiU BuIU9bKmuV8D3A01AgVHyH6ausb9vflDXMgGfFfXcVY+u0IOx7+yMIKlpcDuzTk2GmOiyK5Xspx8K pGM0LxR7bwKKyGzbJ/n988Qg35PoON/uK66gWkNbg+OTKpsi40cjQdPj+3dte7GKElLBDPtqCqy85 m16IbS/XSbqTsZ8w5QkSS+iasbB0WhmKskQmyuQLBGOO/MfKvTk77PIyWBcPjlpHsmi7gvmIbbQSm cioH2LLW75OWiNygl2EA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJNRn-0005DF-QT; Sun, 04 Nov 2018 18:48:31 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJNRI-0004jV-Ky for linux-arm-kernel@bombadil.infradead.org; Sun, 04 Nov 2018 18:48:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OtXhT+RpZBLfA/cy8Ab5d6XW50GT5040rSyOqcUy+QY=; b=IwQPVCGR4IUJueCACClTQIwt2V W81RiNEI+TBvzxu5bdE39/lYXrPo+vGR7tUQC5WKH9siB+8qiLY+0fuColGtwJ2BXGwe1cQSGmgCm opFeKZYa5lxlCX8jmLBe1xTud7E+hryYKlNg4V3V321mUxWMWTDx1EHLyumvLFyRIVIK6qD7RzRmA I6D9ERdpeoEO1TT30Qd9se5jP7CuJE6sKn0Ysnx/x8X7+zwEG1mI9lWaut0r2OGRYYwilz5kI9uXw XR/uH0sq5wBAkbo7Q1puOuuh4Gj3twfpj03NJr/T+cuJYfD7CLMLnipO1wwL2hYuTBJitO8RGWibx x+bPXpZg==; Received: from mailoutvs56.siol.net ([185.57.226.247] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJN8i-0005X4-0d for linux-arm-kernel@lists.infradead.org; Sun, 04 Nov 2018 18:28:48 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 699D2521233; Sun, 4 Nov 2018 19:28:34 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id hcEQx_yLs5GF; Sun, 4 Nov 2018 19:28:33 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id A984B52128A; Sun, 4 Nov 2018 19:28:33 +0100 (CET) Received: from localhost.localdomain (cpe1-8-82.cable.triera.net [213.161.8.82]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id 434835212AE; Sun, 4 Nov 2018 19:28:31 +0100 (CET) From: Jernej Skrabec <jernej.skrabec@siol.net> To: maxime.ripard@bootlin.com, wens@csie.org Subject: [PATCH v3 23/28] drm/sun4i: Initialize registers in tcon-top driver Date: Sun, 4 Nov 2018 19:27:00 +0100 Message-Id: <20181104182705.18047-24-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181104182705.18047-1-jernej.skrabec@siol.net> References: <20181104182705.18047-1-jernej.skrabec@siol.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181104_132848_238278_22514577 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: devicetree@vger.kernel.org, architt@codeaurora.org, a.hajda@samsung.com, sboyd@kernel.org, mturquette@baylibre.com, jernej.skrabec@siol.net, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-sunxi@googlegroups.com, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
Allwinner H6 DE3 and HDMI support
|
expand
|
diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c index 3040a79f298f..37158548b447 100644 --- a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c +++ b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c @@ -167,6 +167,13 @@ static int sun8i_tcon_top_bind(struct device *dev, struct device *master, goto err_assert_reset; } + /* + * At least on H6, some registers have some bits set by default + * which may cause issues. Clear them here. + */ + writel(0, regs + TCON_TOP_PORT_SEL_REG); + writel(0, regs + TCON_TOP_GATE_SRC_REG); + /* * TCON TOP has two muxes, which select parent clock for each TCON TV * channel clock. Parent could be either TCON TV or TVE clock. For now
It turns out that TCON TOP registers in H6 SoC have non-zero reset value. This may cause issues if bits are not changed during configuration. To prevent that, initialize registers to 0. Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 7 +++++++ 1 file changed, 7 insertions(+)