diff mbox series

[v3,4/4] arm64: dts: actions: s700-cubieboard7: Enable SIRQ

Message ID 20181126100940.2944780-1-pn@denx.de (mailing list archive)
State New, archived
Headers show
Series Add Actions Semi Owl family sirq support | expand

Commit Message

Parthiban Nallathambi Nov. 26, 2018, 10:09 a.m. UTC
Add pinctrl definitions for Actions Semiconductor S700 SIRQ external
interrupt controller.

Signed-off-by: Parthiban Nallathambi <pn@denx.de>
---
 .../boot/dts/actions/s700-cubieboard7.dts     | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

kernel test robot Nov. 26, 2018, 4:59 p.m. UTC | #1
Hi Parthiban,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on v4.20-rc4 next-20181126]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Parthiban-Nallathambi/Add-Actions-Semi-Owl-family-sirq-support/20181126-181439
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/actions/s700-cubieboard7.dts:46.1-9 Label or path pinctrl not found
>> FATAL ERROR: Syntax error parsing input tree

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Parthiban Nallathambi Nov. 26, 2018, 5:37 p.m. UTC | #2
On 11/26/18 5:59 PM, kbuild test robot wrote:
> Hi Parthiban,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on tip/irq/core]
> [also build test ERROR on v4.20-rc4 next-20181126]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Parthiban-Nallathambi/Add-Actions-Semi-Owl-family-sirq-support/20181126-181439
> config: arm64-allmodconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # save the attached .config to linux build tree
>          GCC_VERSION=7.2.0 make.cross ARCH=arm64
> 
> All errors (new ones prefixed by >>):
> 
>>> Error: arch/arm64/boot/dts/actions/s700-cubieboard7.dts:46.1-9 Label or path pinctrl not found
>>> FATAL ERROR: Syntax error parsing input tree

For the reference, this patch depends on pinctrl for s700, which is yet
to be merged.

https://lore.kernel.org/patchwork/patch/1012859/

> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
index 28f3f4a0f7f0..af44fd0456cf 100644
--- a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
+++ b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
@@ -37,3 +37,22 @@ 
 &uart3 {
 	status = "okay";
 };
+
+&sirq {
+	pinctrl-names = "default";
+	pinctrl-0 = <&sirq2_default>;
+};
+
+&pinctrl {
+	sirq2_default: sirq2_default {
+		pinmux {
+			groups = "sirq2_dummy";
+			function = "sirq2";
+		};
+
+		pinconf {
+			pins = "sirq2";
+			bias-pull-pin-default;
+		};
+	};
+};