| Message ID | 20181213230411.5009-3-tony@atomide.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 7c695e87bd7a88298d2c00b5e14cf71d0a2a8663 |
| Headers | show |
| Series | [1/3] ARM: dts: Add wlcore wakeirq for omap3-evm | expand |
Hi, On Thu, Dec 13, 2018 at 03:04:11PM -0800, Tony Lindgren wrote: > With wlcore supporting optional wakeirqs, we can configure it > for pandaboard. -ENOPANDA -- Sebastian > This makes ssh connection usable with the SoC > entering deeper idle states. > > Let's configure a wakeirq both for the wlcore GPIO and the SDIO > dat1 pin in case wlcore starts supporting SDIO dat1 interrupt at > some point. > > And let's also add the missing keep-power-in-suspend while at it. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/boot/dts/omap4-droid4-xt894.dts | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > @@ -359,20 +359,24 @@ > > &mmc3 { > vmmc-supply = <&wl12xx_vmmc>; > + /* uart2_tx.sdmmc3_dat1 pad as wakeirq */ > interrupts-extended = <&wakeupgen GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH > &omap4_pmx_core 0xde>; > - > + interrupt-names = "irq", "wakeup"; > non-removable; > bus-width = <4>; > cap-power-off-card; > + keep-power-in-suspend; > > #address-cells = <1>; > #size-cells = <0>; > wlcore: wlcore@2 { > compatible = "ti,wl1285", "ti,wl1283"; > reg = <2>; > - interrupt-parent = <&gpio4>; > - interrupts = <4 IRQ_TYPE_EDGE_RISING>; /* gpio100 */ > + /* gpio_100 with gpmc_wait2 pad as wakeirq */ > + interrupts-extended = <&gpio4 4 IRQ_TYPE_EDGE_RISING>, > + <&omap4_pmx_core 0x4e>; > + interrupt-names = "irq", "wakeup"; > ref-clock-frequency = <26000000>; > tcxo-clock-frequency = <26000000>; > }; > -- > 2.19.2
* Sebastian Reichel <sre@kernel.org> [181213 23:22]: > Hi, > > On Thu, Dec 13, 2018 at 03:04:11PM -0800, Tony Lindgren wrote: > > With wlcore supporting optional wakeirqs, we can configure it > > for pandaboard. > > -ENOPANDA Oops, thanks for catching the typo. Updated patch below. Regards, Tony 8< ---------------------- From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren <tony@atomide.com> Date: Thu, 13 Dec 2018 15:03:21 -0800 Subject: [PATCH] ARM: dts: omap4-droid4: Configure wlcore wakeirq With wlcore supporting optional wakeirqs, we can configure it for droid 4. This makes ssh connection usable with the SoC entering deeper idle states. Let's configure a wakeirq both for the wlcore GPIO and the SDIO dat1 pin in case wlcore starts supporting SDIO dat1 interrupt at some point. And let's also add the missing keep-power-in-suspend while at it. Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/omap4-droid4-xt894.dts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts @@ -359,20 +359,24 @@ &mmc3 { vmmc-supply = <&wl12xx_vmmc>; + /* uart2_tx.sdmmc3_dat1 pad as wakeirq */ interrupts-extended = <&wakeupgen GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH &omap4_pmx_core 0xde>; - + interrupt-names = "irq", "wakeup"; non-removable; bus-width = <4>; cap-power-off-card; + keep-power-in-suspend; #address-cells = <1>; #size-cells = <0>; wlcore: wlcore@2 { compatible = "ti,wl1285", "ti,wl1283"; reg = <2>; - interrupt-parent = <&gpio4>; - interrupts = <4 IRQ_TYPE_EDGE_RISING>; /* gpio100 */ + /* gpio_100 with gpmc_wait2 pad as wakeirq */ + interrupts-extended = <&gpio4 4 IRQ_TYPE_EDGE_RISING>, + <&omap4_pmx_core 0x4e>; + interrupt-names = "irq", "wakeup"; ref-clock-frequency = <26000000>; tcxo-clock-frequency = <26000000>; };
diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts @@ -359,20 +359,24 @@ &mmc3 { vmmc-supply = <&wl12xx_vmmc>; + /* uart2_tx.sdmmc3_dat1 pad as wakeirq */ interrupts-extended = <&wakeupgen GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH &omap4_pmx_core 0xde>; - + interrupt-names = "irq", "wakeup"; non-removable; bus-width = <4>; cap-power-off-card; + keep-power-in-suspend; #address-cells = <1>; #size-cells = <0>; wlcore: wlcore@2 { compatible = "ti,wl1285", "ti,wl1283"; reg = <2>; - interrupt-parent = <&gpio4>; - interrupts = <4 IRQ_TYPE_EDGE_RISING>; /* gpio100 */ + /* gpio_100 with gpmc_wait2 pad as wakeirq */ + interrupts-extended = <&gpio4 4 IRQ_TYPE_EDGE_RISING>, + <&omap4_pmx_core 0x4e>; + interrupt-names = "irq", "wakeup"; ref-clock-frequency = <26000000>; tcxo-clock-frequency = <26000000>; };
With wlcore supporting optional wakeirqs, we can configure it for pandaboard. This makes ssh connection usable with the SoC entering deeper idle states. Let's configure a wakeirq both for the wlcore GPIO and the SDIO dat1 pin in case wlcore starts supporting SDIO dat1 interrupt at some point. And let's also add the missing keep-power-in-suspend while at it. Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/omap4-droid4-xt894.dts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)