diff mbox series

[v2,2/2] arm64: dts: meson: add g12a x96 max board

Message ID 20181219233519.35287-2-khilman@baylibre.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings | expand

Commit Message

Kevin Hilman Dec. 19, 2018, 11:35 p.m. UTC
Add the G12a (S905X2) based X96 Max board[1].

There is no branding for the manufacturer anywhere on the product, so it
took some digging to find the manufacturer.  But since there's nothing
about the maker on the product I've left it out of the DT name because
1) nobody will know that name and 2) keeps the DT filename shorter.

[1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/

Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
 .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts

Comments

Neil Armstrong Jan. 21, 2019, 10:43 a.m. UTC | #1
Hi Kevin,

On 20/12/2018 00:35, Kevin Hilman wrote:
> Add the G12a (S905X2) based X96 Max board[1].
> 
> There is no branding for the manufacturer anywhere on the product, so it
> took some digging to find the manufacturer.  But since there's nothing
> about the maker on the product I've left it out of the DT name because
> 1) nobody will know that name and 2) keeps the DT filename shorter.
> 
> [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/
> 
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
>  .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++

Just found out you forgot to update the Makefile !!

Neil

[snip]

> +
> +&uart_AO {
> +	status = "okay";
> +};
>
Kevin Hilman Jan. 31, 2019, 4:48 p.m. UTC | #2
Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Kevin,
>
> On 20/12/2018 00:35, Kevin Hilman wrote:
>> Add the G12a (S905X2) based X96 Max board[1].
>> 
>> There is no branding for the manufacturer anywhere on the product, so it
>> took some digging to find the manufacturer.  But since there's nothing
>> about the maker on the product I've left it out of the DT name because
>> 1) nobody will know that name and 2) keeps the DT filename shorter.
>> 
>> [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/
>> 
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>>  .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++
>
> Just found out you forgot to update the Makefile !!

D'oh, fixing for v3.

Kevin
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
new file mode 100644
index 000000000000..c62d3d5706ff
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -0,0 +1,28 @@ 
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 BayLibre SAS. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "meson-g12a.dtsi"
+
+/ {
+	compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a";
+	model = "Shenzhen Amediatech Technology Co., Ltd X96 Max";
+
+	aliases {
+		serial0 = &uart_AO;
+	};
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x0 0x0 0x40000000>;
+	};
+};
+
+&uart_AO {
+	status = "okay";
+};