| Message ID | 20181220102247.4911-4-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | driver core: add probe error check helper | expand |
On Thu, Dec 20, 2018 at 11:23 AM Andrzej Hajda <a.hajda@samsung.com> wrote: > > probe_err is useful in multiple contexts where error is encoded in pointer. > Adding helper performing conversion to error value should simplify code > further. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > include/linux/device.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/device.h b/include/linux/device.h > index 2d3a1cc6f5da..50632414c363 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -1594,6 +1594,8 @@ do { \ > extern __printf(3, 4) > int probe_err(const struct device *dev, int err, const char *fmt, ...); > > +#define probe_err_ptr(dev, ptr, args...) probe_err(dev, PTR_ERR(ptr), args) > + > /* Create alias, so I can be autoloaded. */ > #define MODULE_ALIAS_CHARDEV(major,minor) \ > MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor)) > -- > 2.17.1 >
On Thu, Dec 20, 2018 at 11:22:47AM +0100, Andrzej Hajda wrote: > probe_err is useful in multiple contexts where error is encoded in pointer. > Adding helper performing conversion to error value should simplify code > further. Same question as on patch 1/3, please some someone using this. Also, it's too late for 4.21, so no rush on this. My trees are now closed. thanks, greg k-h
diff --git a/include/linux/device.h b/include/linux/device.h index 2d3a1cc6f5da..50632414c363 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -1594,6 +1594,8 @@ do { \ extern __printf(3, 4) int probe_err(const struct device *dev, int err, const char *fmt, ...); +#define probe_err_ptr(dev, ptr, args...) probe_err(dev, PTR_ERR(ptr), args) + /* Create alias, so I can be autoloaded. */ #define MODULE_ALIAS_CHARDEV(major,minor) \ MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor))
probe_err is useful in multiple contexts where error is encoded in pointer. Adding helper performing conversion to error value should simplify code further. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- include/linux/device.h | 2 ++ 1 file changed, 2 insertions(+)