| Message ID | 20190113153022.5040-2-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PatchV2,1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning | expand |
Hi Anand, On 13/01/2019 16:30, Anand Moon wrote: > Add missing vin-supply node 5.0V regulator setting to power > to usb ports, changes help fix the usb reset warning. > > [ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes) > Tested-by: Kevin Hilman <khilman@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > Rebased on Kevin's amlogic/v5.0/fixes branch > Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/ > - Split the patch into two part: new patch > - Fix the commit message > - Added Tested by Kevin Hilman > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > index 25a36d117183..a947b46bfaa8 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > @@ -28,6 +28,13 @@ > reg = <0x0 0x0 0x0 0x80000000>; > }; > > + p5v0: regulator-p5v0 { > + compatible = "regulator-fixed"; > + regulator-name = "P5V0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + > usb_otg_pwr: regulator-usb-pwrs { > compatible = "regulator-fixed"; > > @@ -36,6 +43,8 @@ > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > > + vin-supply = <&p5v0>; > + > gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> PS: Please add a cover-letter next time ! Neil
Hi Anand, Anand Moon <linux.amoon@gmail.com> writes: > Add missing vin-supply node 5.0V regulator setting to power > to usb ports, changes help fix the usb reset warning. > > [ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > [ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes) > Tested-by: Kevin Hilman <khilman@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > Rebased on Kevin's amlogic/v5.0/fixes branch > Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/ > - Split the patch into two part: new patch > - Fix the commit message > - Added Tested by Kevin Hilman Queued as fixes for v5.0-rc (branch: v5.0/fixes) with Neil's reviewed-by tags. Thanks for breaking up into two patches, and as Neil said, please add a cover letter to multi-patch series in the future. Thanks, Kevin
Hi Kevin / Neil On Mon, 14 Jan 2019 at 21:52, Kevin Hilman <khilman@baylibre.com> wrote: > > Hi Anand, > > Anand Moon <linux.amoon@gmail.com> writes: > > > Add missing vin-supply node 5.0V regulator setting to power > > to usb ports, changes help fix the usb reset warning. > > > > [ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > [ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > [ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > [ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > [ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2 > > > > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes) > > Tested-by: Kevin Hilman <khilman@baylibre.com> > > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Cc: Jerome Brunet <jbrunet@baylibre.com> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > Rebased on Kevin's amlogic/v5.0/fixes branch > > Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/ > > - Split the patch into two part: new patch > > - Fix the commit message > > - Added Tested by Kevin Hilman > > Queued as fixes for v5.0-rc (branch: v5.0/fixes) with Neil's reviewed-by tags. > > Thanks for breaking up into two patches, and as Neil said, please add a > cover letter to multi-patch series in the future. > > Thanks, > > Kevin Ok will follow the protocol next time I send some patches. Best Regards -Anand
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 25a36d117183..a947b46bfaa8 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -28,6 +28,13 @@ reg = <0x0 0x0 0x0 0x80000000>; }; + p5v0: regulator-p5v0 { + compatible = "regulator-fixed"; + regulator-name = "P5V0"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; + usb_otg_pwr: regulator-usb-pwrs { compatible = "regulator-fixed"; @@ -36,6 +43,8 @@ regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; + vin-supply = <&p5v0>; + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; enable-active-high; };