From patchwork Sun Jan 20 01:58:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angus Ainslie X-Patchwork-Id: 10772247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6649E746 for ; Sun, 20 Jan 2019 01:59:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FFF62A945 for ; Sun, 20 Jan 2019 01:59:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 422362A947; Sun, 20 Jan 2019 01:59:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D3C382A945 for ; Sun, 20 Jan 2019 01:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rfl3zNON+onmSKlnKfMBDeAJtGJw+9Yb0T+qW7I/qeQ=; b=Yb91lIXBIrfwOxlCetZJCK4NXk C2uG5uDephY0OlAM9miMxF7AzXRiuSFLouXzstssP9YV0fGPHcrsdwlwktvOuR9Z6TBBbiehV/rg4 pMCyesEhHAmx+y9j+WwhRt0WZ1x+nGiBGN1fJsveLoMQU457OwvsjBu+v12a/hQ5J8Vcnt2dYfZKu 7nLnrS8A4XQ1GC7qKXMBRejHstJumFNpC6EGtwFSkyK0pPQDLMiEmYI8NGGeHHIKLpd81VppCitQM s70eVyCnENONgcFfM0vi15e3JlSPWL0CD681GOdtVr6cq12xTlBJcl7OOgGMj+ArvCjwkPnm8Kpb0 Cg6YV/sQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gl2Ok-00082J-OB; Sun, 20 Jan 2019 01:59:42 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gl2OB-0007XU-Ks for linux-arm-kernel@lists.infradead.org; Sun, 20 Jan 2019 01:59:09 +0000 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 6AB5A4E2051; Sun, 20 Jan 2019 01:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1547949542; bh=wxj4KQZd68U4CteRg0LBuiQpkZAAQQhF+vq81skObRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ojK+jmY84YyQYcxCHDRCg5LVJr2eIuuenKTQC8ndf4Am9brlHWNjclzDyrjPrlwPQ 5qj+WLPgY0Skzu0OY9qtMB8oMV7hc9cdN0KTsGMbU6LliwYwrHRkHo6aIG9Q7aMFb5 nGUVHFZogUlMXfAesHgWSdj5lT/o/hmSt1ea+6JE= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7q5NT6QLraNd; Sun, 20 Jan 2019 01:59:02 +0000 (UTC) Received: from localhost.localdomain (198-48-167-13.cpe.pppoe.ca [198.48.167.13]) by node.akkea.ca (Postfix) with ESMTPSA id 91C8D4E204D; Sun, 20 Jan 2019 01:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1547949542; bh=wxj4KQZd68U4CteRg0LBuiQpkZAAQQhF+vq81skObRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ojK+jmY84YyQYcxCHDRCg5LVJr2eIuuenKTQC8ndf4Am9brlHWNjclzDyrjPrlwPQ 5qj+WLPgY0Skzu0OY9qtMB8oMV7hc9cdN0KTsGMbU6LliwYwrHRkHo6aIG9Q7aMFb5 nGUVHFZogUlMXfAesHgWSdj5lT/o/hmSt1ea+6JE= From: "Angus Ainslie (Purism)" To: angus@akkea.ca Subject: [PATCH 1/3] dma: imx-sdma: fix NULL pointer de-reference Date: Sat, 19 Jan 2019 18:58:49 -0700 Message-Id: <20190120015851.11797-2-angus@akkea.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190120015851.11797-1-angus@akkea.ca> References: <20190120015851.11797-1-angus@akkea.ca> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190119_175907_688723_1822CE5C X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Vinod Koul , NXP Linux Team , Pengutronix Kernel Team , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On the imx8mq I get NULL pointer de-deference errors if the device isn't passed in during allocation. Signed-off-by: Angus Ainslie (Purism) --- drivers/dma/imx-sdma.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 86708fb9bda1..064bc50d1e99 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -677,7 +677,7 @@ static int sdma_load_script(struct sdma_engine *sdma, void *buf, int size, int ret; unsigned long flags; - buf_virt = dma_alloc_coherent(NULL, size, &buf_phys, GFP_KERNEL); + buf_virt = dma_alloc_coherent(sdma->dev, size, &buf_phys, GFP_KERNEL); if (!buf_virt) { return -ENOMEM; } @@ -696,7 +696,7 @@ static int sdma_load_script(struct sdma_engine *sdma, void *buf, int size, spin_unlock_irqrestore(&sdma->channel_0_lock, flags); - dma_free_coherent(NULL, size, buf_virt, buf_phys); + dma_free_coherent(sdma->dev, size, buf_virt, buf_phys); return ret; } @@ -1182,8 +1182,8 @@ static int sdma_request_channel0(struct sdma_engine *sdma) { int ret = -EBUSY; - sdma->bd0 = dma_alloc_coherent(NULL, PAGE_SIZE, &sdma->bd0_phys, - GFP_NOWAIT); + sdma->bd0 = dma_zalloc_coherent(sdma->dev, PAGE_SIZE, &sdma->bd0_phys, + GFP_NOWAIT); if (!sdma->bd0) { ret = -ENOMEM; goto out; @@ -1205,8 +1205,8 @@ static int sdma_alloc_bd(struct sdma_desc *desc) u32 bd_size = desc->num_bd * sizeof(struct sdma_buffer_descriptor); int ret = 0; - desc->bd = dma_alloc_coherent(NULL, bd_size, &desc->bd_phys, - GFP_NOWAIT); + desc->bd = dma_zalloc_coherent(desc->sdmac->sdma->dev, bd_size, + &desc->bd_phys, GFP_NOWAIT); if (!desc->bd) { ret = -ENOMEM; goto out; @@ -1219,7 +1219,8 @@ static void sdma_free_bd(struct sdma_desc *desc) { u32 bd_size = desc->num_bd * sizeof(struct sdma_buffer_descriptor); - dma_free_coherent(NULL, bd_size, desc->bd, desc->bd_phys); + dma_free_coherent(desc->sdmac->sdma->dev, bd_size, desc->bd, + desc->bd_phys); } static void sdma_desc_free(struct virt_dma_desc *vd) @@ -1842,7 +1843,7 @@ static int sdma_init(struct sdma_engine *sdma) /* Be sure SDMA has not started yet */ writel_relaxed(0, sdma->regs + SDMA_H_C0PTR); - sdma->channel_control = dma_alloc_coherent(NULL, + sdma->channel_control = dma_alloc_coherent(sdma->dev, MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control) + sizeof(struct sdma_context_data), &ccb_phys, GFP_KERNEL);