| Message ID | 20190123230733.1821501-1-vijaykhemka@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: aspeed: Add peci and lpc for Facebook | expand |
On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote: > index 73e58a821613..d60dbb019f82 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > > +&peci0 { > + status = "okay"; > +}; I don't think we have an upstream tree that contains a node called peci0. Therefore this does not build. I have dropped this hunk from your patch. Please make sure you test before sending patches. Cheers, Joel
On 1/29/19, 7:27 PM, "Joel Stanley" <joel@jms.id.au> wrote:
On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote:
> index 73e58a821613..d60dbb019f82 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>
> +&peci0 {
> + status = "okay";
> +};
I don't think we have an upstream tree that contains a node called
peci0. Therefore this does not build.
I have dropped this hunk from your patch. Please make sure you test
before sending patches.
Thanks Joel, I will be careful.
Cheers,
Joel
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts index 73e58a821613..d60dbb019f82 100644 --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts @@ -54,6 +54,16 @@ }; }; +&lpc_snoop { + status = "okay"; + snoop-ports = <0x80>; +}; + +&lpc_ctrl { + // Enable lpc clock + status = "okay"; +}; + &uart1 { // Host Console status = "okay"; @@ -67,6 +77,10 @@ status = "okay"; }; +&peci0 { + status = "okay"; +}; + &kcs2 { // BMC KCS channel 2 status = "okay";
Added lpc control for enabling lpc clock, peci for cpu sensors and lpc snoop devices to Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> --- .../arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)