| Message ID | 20190129080324.18708-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data" | expand |
YueHaibing <yuehaibing@huawei.com> writes: > Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") > kfree, iounmap, clk_put etc no need do any more in remove path. > > Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Sorry for the late reply, I had forgotten to answer. Queued to pxa/for-next with a small spelling fix in the commit message, thanks. Cheers. -- Robert
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index ed36dca..bf25f78 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -183,25 +183,16 @@ static int pxa_ssp_probe(struct platform_device *pdev) static int pxa_ssp_remove(struct platform_device *pdev) { - struct resource *res; struct ssp_device *ssp; ssp = platform_get_drvdata(pdev); if (ssp == NULL) return -ENODEV; - iounmap(ssp->mmio_base); - - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, resource_size(res)); - - clk_put(ssp->clk); - mutex_lock(&ssp_lock); list_del(&ssp->node); mutex_unlock(&ssp_lock); - kfree(ssp); return 0; }
Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") kfree, iounmap, clk_put etc no need do any more in remove path. Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/arm/plat-pxa/ssp.c | 9 --------- 1 file changed, 9 deletions(-)