mbox series

[GIT,PULL,3/3] ARM: lpc32xx: NXP LPC32xx platform changes for 5.1

Message ID 20190203212936.17053-3-vz@mleia.com (mailing list archive)
State Mainlined, archived
Commit 49bb0b964c1f067aeb282e85e42123cc36b7b147
Headers show
Series [GIT,PULL,1/3] ARM: defconfig: NXP LPC32xx and LPC18xx/LPC43xx changes for 5.1 | expand

Pull-request

https://github.com/vzapolskiy/linux-lpc32xx tags/lpc32xx-soc-for-5.1

Message

Vladimir Zapolskiy Feb. 3, 2019, 9:29 p.m. UTC
Hi Arnd, Olof and Kevin,

please consider to pull the updates to NXP LPC32xx platform files, the work
of moving platform data into particular board dts files has been continued.

The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c:

  Linux 5.0-rc1 (2019-01-06 17:08:20 -0800)

are available in the Git repository at:

  https://github.com/vzapolskiy/linux-lpc32xx tags/lpc32xx-soc-for-5.1

for you to fetch changes up to 49bb0b964c1f067aeb282e85e42123cc36b7b147:

  ARM: lpc32xx: remove platform data of ARM PL111 LCD controller (2019-02-03 21:40:41 +0200)

----------------------------------------------------------------
ARM: lpc32xx: platform updates for v5.1

Here are the changes for ARM NXP LPC32xx platform files:

* removed a superfluous record to kernel log buffer under OOM condition,
* use kmemdup() helper instead of kmalloc()/memcpy() pair,
* removed platform data of ARM PL180 SD/MMC and ARM PL111 LCD controllers,
  since now both are handled in devicetree files.

----------------------------------------------------------------
Markus Elfring (1):
      ARM: lpc32xx: Delete an error message for a failed memory allocation in lpc32xx_pm_enter()

Vladimir Zapolskiy (2):
      ARM: lpc32xx: remove platform data of ARM PL180 SD/MMC controller
      ARM: lpc32xx: remove platform data of ARM PL111 LCD controller

zhong jiang (1):
      ARM: lpc32xx: Use kmemdup to replace duplicating its implementation

 arch/arm/mach-lpc32xx/phy3250.c | 84 -------------------------------------------------
 arch/arm/mach-lpc32xx/pm.c      | 13 ++------
 2 files changed, 3 insertions(+), 94 deletions(-)

--
Best wishes,
Vladimir

Comments

Arnd Bergmann Feb. 15, 2019, 4:53 p.m. UTC | #1
On Sun, Feb 3, 2019 at 10:29 PM Vladimir Zapolskiy <vz@mleia.com> wrote:

>
> ----------------------------------------------------------------
> ARM: lpc32xx: platform updates for v5.1
>
> Here are the changes for ARM NXP LPC32xx platform files:
>
> * removed a superfluous record to kernel log buffer under OOM condition,
> * use kmemdup() helper instead of kmalloc()/memcpy() pair,
> * removed platform data of ARM PL180 SD/MMC and ARM PL111 LCD controllers,
>   since now both are handled in devicetree files.

Nice code reduction for phy32xx!

I wonder if we ever go the pl08x DT support to the state of removing that
as well, I think Linus Walleij also looked into this in the past, but we still
seem to have this on spear, s3c64xx along with lpc32xx.

Pulled into arm/soc, thanks!

      Arnd
Linus Walleij Feb. 21, 2019, 12:35 p.m. UTC | #2
On Fri, Feb 15, 2019 at 5:53 PM Arnd Bergmann <arnd@arndb.de> wrote:

> I wonder if we ever go the pl08x DT support to the state of removing that
> as well, I think Linus Walleij also looked into this in the past, but we still
> seem to have this on spear, s3c64xx along with lpc32xx.

I looked into it at one point, started making patches but they became
large and scary :D but that was mostly because of SPEAr
strangeness.

The LPC32xx should be an easy conversion to DT because it does
not use custom signal handling. Are you sure it doesn't "just work"?
arch/arm/mach-lpc32xx/phy3250.c does not look like it's doing
anything the driver can't do from device tree already.

Look at:
arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
for an example wikth PL08x and DMA on two UARTs.

Yours,
Linus Walleij