From patchwork Fri Feb 8 22:35:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 10803853 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 41B4313BF for ; Fri, 8 Feb 2019 22:35:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 321DF2ECB6 for ; Fri, 8 Feb 2019 22:35:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 263072ED35; Fri, 8 Feb 2019 22:35:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C64892ECB6 for ; Fri, 8 Feb 2019 22:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=oR58ZcLFrR1O3zbiMUQdqq8YYG5rryXaChNpKx8AtBc=; b=CIArU7RKlrKDPI NlYDWMEA/3BHIlH8Fgr1dXOGu1ml+jqkbXf5A7dvhOBHfKwy2oBvgvUC53638FaXQ/oKq+aSq1Jz9 qx9eG1R9zJ/iEHQZr1sw8X/1MarnbW76qNsripAdiEbX3BsKqwa6siQXa6csyXja9KZHYwWgotEJI y523t2BPvY/0aS28J9yTCRWbf5/BhwLjn3IaxiHUkd7/QiRie5XXeM+HdAUX6ikiPeEfGv4/kHIE4 AKmfhaaggLYGd4a/jqhHUFBkQ4IhtoSaJ01zcystETmyE4jpk7UT5p4g5QBGKTwsZzBkDFVEjkuBW Y8nFJSXs1Q629YdTaAGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsEkP-0006pX-97; Fri, 08 Feb 2019 22:35:49 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsEkM-0006p4-N2 for linux-arm-kernel@lists.infradead.org; Fri, 08 Feb 2019 22:35:48 +0000 Received: by mail-pl1-x644.google.com with SMTP id p4so2340570plq.11 for ; Fri, 08 Feb 2019 14:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i6GftFjwiUCvtcxvEAR034ySjK3PZ5xc2bnvkHKBDpk=; b=bun0wgKexaPR9h1OnV4KNy3aKndX2kD6XNTFbuR6SjmfPYmiiApvRoy+EDadujf8lr L6DiA66LmluEXijU+iVgYFs9wY+QXXCf81bQHP4QfS00zuGXMK2AsEKfclZoAWEp1jpO CVMMYWzNdbm+jPau6bNJ0StEAHUAKJ1B/FrDj/YovDMrGLhqW5250mMpiRSzKEvOWRCR BYl/fT7VKrpROvNNb7xSRMTNljt2JIv0jL0jYXgp6g3psaivxqLrTv26pUpuyqCOMoMW tdGzEva6qK6vbQVPGeafzaWet2C85C/8cZX22Xasad3TIgHCdQso7fuwSsiJ6oapASho +FKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i6GftFjwiUCvtcxvEAR034ySjK3PZ5xc2bnvkHKBDpk=; b=WmQs9pYus8fHJeF1JEx2uS/8lu+lIKKgaSWBGNILmUkFOeOI1yglKoZyjXgxepZyVW x4ey7Xuh+nCkyDpNCXyjGcEmvaCuQT1Hb6WkD3P37w2vScxHG2QU4ZPfjz5wEWMbMOY7 rLAlALLfPKOgG2IS9g8lyU4VV4METaTQLIOntF+iiR+VGWHIb8OGx9urLTsl59V6D/2G M6xFzGdK/sgdek+ghByBToaoz3fjhKOqpWwLPubAtNlkh+6iB07S8htNVsS1xm+szyyG qAtswJzFartExBQuc5cCpnz4Uz2enJy9CPG/Z4rtcEwXb8qoyiAxunwPRf9zAnYu8hLN vqIQ== X-Gm-Message-State: AHQUAubeO0BG0ltPoHWPvCMcJrio7PvRhCmb0XtGLMFExFylx9jbvBaU HC4luS2ffvJTUDFhA2dtHHSeWQ== X-Google-Smtp-Source: AHgI3IZbdR+luYjf6iojCCnmknIkV2mhrkTAJ9dJF/07q98Gth8zpCHzJpWXXtIH6n9fiUHHMtP57A== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr24548278pla.252.1549665345364; Fri, 08 Feb 2019 14:35:45 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id h8sm3610634pgv.27.2019.02.08.14.35.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 14:35:44 -0800 (PST) From: Mathieu Poirier To: acme@kernel.org Subject: [PATCH] perf tools: Add proper header file for symbols Date: Fri, 8 Feb 2019 15:35:43 -0700 Message-Id: <20190208223543.31836-1-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190208_143546_780249_6F285E51 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, peterz@infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, jolsa@redhat.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP After 'commit e22c1c751140 ("perf thread: Don't include symbol.h, symbol_conf.h is enough")' Compilation of the perf tools is broken when using the functionality provided by the openCSD library: [...] ... timerfd: [ on ] ... sched_getcpu: [ on ] ... sdt: [ OFF ] ... setns: [ on ] ... libopencsd: [ on ] [...] CC util/arm-spe.o CC util/arm-spe-pkt-decoder.o CC util/s390-cpumsf.o CC util/cs-etm.o CC util/parse-branch-options.o util/cs-etm.c: In function ‘cs_etm__mem_access’: util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known struct addr_location al; And rightly so since file cs-etm.c doesn't include symbol.h, something that is rectified in this patch. Signed-off-by: Mathieu Poirier --- tools/perf/util/cs-etm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 8b3f882d6e2f..0b11d653cfbe 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -25,6 +25,7 @@ #include "machine.h" #include "map.h" #include "perf.h" +#include "symbol.h" #include "thread.h" #include "thread_map.h" #include "thread-stack.h"