| Message ID | 20190212151413.24632-2-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: meson: Add support for USB on Amlogic G12A | expand |
On Tue, Feb 12, 2019 at 4:14 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Add the Amlogic G12A Family USB2 OTG PHY Bindings nit-pick: if you want to keep "OTG" in there then please add a short description how OTG works on this PHY. I would describe this as: "Add the Amlogic G12A Family USB2 PHY Bindings. The PHY works for host or peripheral modes. Configuration of the mode is part of the USBCTRL registers which are outside of the PHY registers." > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> with the patch description nit-pick addressed: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Regards Martin
On Tue, 12 Feb 2019 16:14:06 +0100, Neil Armstrong wrote: > Add the Amlogic G12A Family USB2 OTG PHY Bindings > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../bindings/phy/meson-g12a-usb2-phy.txt | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt b/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt new file mode 100644 index 000000000000..a6ebc3dea159 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt @@ -0,0 +1,22 @@ +* Amlogic G12A USB2 PHY binding + +Required properties: +- compatible: Should be "amlogic,meson-g12a-usb2-phy" +- reg: The base address and length of the registers +- #phys-cells: must be 0 (see phy-bindings.txt in this directory) +- clocks: a phandle to the clock of this PHY +- clock-names: must be "xtal" +- resets: a phandle to the reset line of this PHY +- reset-names: must be "phy" +- phy-supply: see phy-bindings.txt in this directory + +Example: + usb2_phy0: phy@36000 { + compatible = "amlogic,g12a-usb2-phy"; + reg = <0x0 0x36000 0x0 0x2000>; + clocks = <&xtal>; + clock-names = "xtal"; + resets = <&reset RESET_USB_PHY21>; + reset-names = "phy"; + #phy-cells = <0>; + };
Add the Amlogic G12A Family USB2 OTG PHY Bindings Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../bindings/phy/meson-g12a-usb2-phy.txt | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt