From patchwork Sat Feb 16 16:31:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 10816305 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6CF5113B5 for ; Sat, 16 Feb 2019 16:32:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 59AA02C3EF for ; Sat, 16 Feb 2019 16:32:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D8522C40C; Sat, 16 Feb 2019 16:32:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 02EC32C3EF for ; Sat, 16 Feb 2019 16:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=upBpOwWtS0szMgn7Y1nJ3XaPeZWbJESrR3qCu9TbiII=; b=Egw 6uZXvuyyTtbdLmfRJkvZvYnXHcEsgjve7iGljxgqHAy9Y0j2W7MhrUoCI5UKZaK4NEiyYY+9nQlLX jM7jScVVf/12AztC7p1NT11b0aZalFZ9GKZsjfdVwk13JwRklKbll3A1dq1ORWwLi270dKx7WoRdj 4NXaTrYB3jamaXnLeTtpK32x5EBy/r9+tCgTTvQNp6baEYJHVCMeL0fJeg0MomRLARQcKOjAcIF9Q ilSxm/Y8sMPppH/HxGwrAmq+jOEeMDITM5FYOajub1R7ffM1tkG3M939uZ5hNNeOxv602hl6COQJG bHHZ2JRGBJ+ACHSS/lA/lxYTAWD20bw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gv2sk-00084V-JW; Sat, 16 Feb 2019 16:32:02 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gv2sg-00083M-VQ for linux-arm-kernel@lists.infradead.org; Sat, 16 Feb 2019 16:32:00 +0000 Received: by mail-pg1-x541.google.com with SMTP id b2so537906pgl.9 for ; Sat, 16 Feb 2019 08:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=LO3QrEf9owC5ZOEMrXxiFtSgd/NWCotfP8eeokdC2i8=; b=PaHX6me/h9dvQWxmJNZs39smveT2uy2UddFwRbuTcGq/9ARB9PsJt0pSJ10sloH9SE /8+G0FtEAB/xfzk9RJ9XiDegqWST7Gjhly2pAY2GkR0KpMfo56rf9OOq/YKV53KLQ4lU hmp+5KVM29VeOS5/j+etuOjOf0N1C/tHQt9/c2SAYZT9vWpv8uAf2OiWcw/RHQScAlNu +jVA5cRmFGRdWvc928IxlO1XIkUg2V5RVSEX/VW9/QlTlX1Zmz9pfW3p8FuGaSf4MprX PkF3tTwGBukjOGontQiOiW9nYqRS4gtj2ju94V593DGUYUE6TBMk8LJNYw33ffKIFdlF ouJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LO3QrEf9owC5ZOEMrXxiFtSgd/NWCotfP8eeokdC2i8=; b=FZPCiaS5b7aT3vAWoVGx97/HrhCB2RTNzQyuqQlYIXUA0phiBhYVhIWgzsnAYHHPqF D6vMK6SEUeq1U5FkEtAvpHM85luUhbeBlOCgLPj3MsAecgGerzmhTeNem6LbYR8z7NFL h/KN+A6FsVGoyjS8iW7/0AkG9AlIdmJRCzwcJXSgTuGwFUJl/OtGHXbzwgRl0Jy8XzoV g6pWqI+KAqv7UXf5Ntg6lJSEP0trXAhELBltiZVDVoND0StPFuSsjgNEJQ2cffgrJDqm FPgyORbnZizaAD1LlSZURWulPNtMge6g44B1lnjKyIIetFelEc641FvdlLPPUwxXlWFk Pb/g== X-Gm-Message-State: AHQUAuZgMCUUyzvRP+/7cJaivCj4TFLNScv9WUtUQeEp5oQX+PgUGQxv hI9asUO57SL2tmlIBm0bdkg= X-Google-Smtp-Source: AHgI3IZA8RrwU96a2b4ROhL2T4Xuw9ulV3+X8XQn3r4wK1JP1Szg2+fr5WaoBClngjdv4YK0LszfJg== X-Received: by 2002:a63:f10c:: with SMTP id f12mr14667460pgi.374.1550334715958; Sat, 16 Feb 2019 08:31:55 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id l22sm14763633pfj.179.2019.02.16.08.31.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Feb 2019 08:31:55 -0800 (PST) From: Yangtao Li To: sudeep.holla@arm.com, rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH] cpufreq: scmi: fix use-after-free in scmi_cpufreq_exit() Date: Sat, 16 Feb 2019 11:31:48 -0500 Message-Id: <20190216163148.12375-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190216_083159_015536_8495FCF5 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yangtao Li , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This issue was detected with the help of Coccinelle. So change the order of function calls to fix it. Fixes: 1690d8bb91e37 (cpufreq: scpi/scmi: Fix freeing of dynamic OPPs) Signed-off-by: Yangtao Li Acked-by: Viresh Kumar Acked-by: Sudeep Holla --- drivers/cpufreq/scmi-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 242c3370544e..9ed46d188cb5 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -187,8 +187,8 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) cpufreq_cooling_unregister(priv->cdev); dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); - kfree(priv); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); + kfree(priv); return 0; }