diff mbox series

clk: at91: programmable: remove unneeded register read

Message ID 20190223000858.28094-1-alexandre.belloni@bootlin.com (mailing list archive)
State Mainlined, archived
Commit 97d010dc420469fbdfcf0b335578f19a0b25e17b
Headers show
Series clk: at91: programmable: remove unneeded register read | expand

Commit Message

Alexandre Belloni Feb. 23, 2019, 12:08 a.m. UTC
From: Nicolas Ferre <nicolas.ferre@microchip.com>

This register read is a leftover of a previous read/modify/write. We now use
regmap_update_bits(), so we don't need it anymore.

Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/clk/at91/clk-programmable.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stephen Boyd Feb. 25, 2019, 5:24 p.m. UTC | #1
Quoting Alexandre Belloni (2019-02-22 16:08:58)
> From: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> This register read is a leftover of a previous read/modify/write. We now use
> regmap_update_bits(), so we don't need it anymore.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/at91/clk-programmable.c b/drivers/clk/at91/clk-programmable.c
index 5bc68b9c5498..89d6f3736dbf 100644
--- a/drivers/clk/at91/clk-programmable.c
+++ b/drivers/clk/at91/clk-programmable.c
@@ -132,11 +132,8 @@  static int clk_programmable_set_rate(struct clk_hw *hw, unsigned long rate,
 	struct clk_programmable *prog = to_clk_programmable(hw);
 	const struct clk_programmable_layout *layout = prog->layout;
 	unsigned long div = parent_rate / rate;
-	unsigned int pckr;
 	int shift = 0;
 
-	regmap_read(prog->regmap, AT91_PMC_PCKR(prog->id), &pckr);
-
 	if (!div)
 		return -EINVAL;