From patchwork Mon Mar 4 18:54:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helen Koike X-Patchwork-Id: 10838237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E834C13B5 for ; Mon, 4 Mar 2019 18:55:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D20562B0DE for ; Mon, 4 Mar 2019 18:55:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C52572B101; Mon, 4 Mar 2019 18:55:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6F5262B0DE for ; Mon, 4 Mar 2019 18:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+0mDa1PfQNt+ye6R5z8mUjt/xKC80V8KPYFY1l1ab64=; b=ddUQ6UkDdr3UG1 WGAp73JIgLTkjtv9AFx6slk7UAEH0G4dNnIRtJj7yZ51TFEB/2BnssLR0sju54pPR7soq49PnHvyL BIb1lPnSkofDciw9VKvlJGX6ngp59vXR82gupy37d37Vu4tS2iuICDpSt9Uw+GQxe1wPac4FRFFaL KrCc6ACpma5r63GIFCJFu1F90rnRGJE1irACrvzYjN0VKgeHg2EH6UPyfGM0NCmHkfmBLqSsdKtHw yNO9SxFbdsoOn6TxEckDYKQP8ZfEPlOtACu3ktZyazppoXq5S30qozbXkAVE7WDcSa8TkJtMH7niO 5102k6G5krNVym2CO7Bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0skG-0007sY-D9; Mon, 04 Mar 2019 18:55:24 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0skC-0007kC-IK; Mon, 04 Mar 2019 18:55:22 +0000 Received: from localhost.localdomain (unknown [IPv6:2804:431:9718:a1b1:9d17:4c45:79a4:9c61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: koike) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id F303326C4B1; Mon, 4 Mar 2019 18:55:04 +0000 (GMT) From: Helen Koike To: eric@anholt.net Subject: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Date: Mon, 4 Mar 2019 15:54:54 -0300 Message-Id: <20190304185454.18043-1-helen.koike@collabora.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_105521_557675_0639A2F7 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, lkundrak@v3.sk, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 driver, the HDMI wans't being detected. So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it works correctly. I can see that modeprint from libdrm detects correctly when the display is plugged and when it is unpluggled. So I was wondering if this is just in my board or if there is an error in the dts (which I think it's unlikely). In any case I am dropping this email here in case anyone else see this problem, if you do, try appliying the patch below. Regards, Helen Reviewed-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts index 5641d162dfdb..28e7513ce617 100644 --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts @@ -93,7 +93,7 @@ }; &hdmi { - hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>; + hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>; }; &pwm {