From patchwork Mon Mar 4 22:28:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10838747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 01FEA1803 for ; Mon, 4 Mar 2019 22:47:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE3A02BAD2 for ; Mon, 4 Mar 2019 22:47:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D21362BC52; Mon, 4 Mar 2019 22:47:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7D4CD2BAD2 for ; Mon, 4 Mar 2019 22:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F28ifPuAqSNj0jcx6ZyUeCgXvoGv/cglxeNwnaI7FVM=; b=KrkurVjAHEP/Qp MKJCINIbng4LOcT3JxrrzFPrDYI/oz0AgCcDWALZx5UZMDYwTBer14aOe0UDrnpM5o1nI37eKa74T ON2oL0HpQN9f0gPU3nJbOIsaBLRFNmlBncn8Y1XBgc1G2Ti7B/MyCkjH0iQUEiWeZUT+805T44fFh jB9ftkr9XNeNSuZqUI4MR+ne1vOcY7EFywO2qTFrqx8BCBB1XkN1X2s7x1si081zmrlbNyU/wZAW8 2j0m5apPmZzoyB0V3wh5HdEFDXwBbqVxci/NW4ajv7x/NTlnyfE5irV0OAfdyoq4nt2OKTcaZLoT6 lEB40eXKJT8hjoKdIIHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0wMx-0000wz-Ot; Mon, 04 Mar 2019 22:47:35 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0wMc-0000N8-FX; Mon, 04 Mar 2019 22:47:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=53XGvWDhq0brHM6dOoHRXDWS7tUPlxpjkXeW7xiDiv4=; b=Dj4GG8xc17rjLxb8vGLXKvCXvT p84wns8B2AlfQKw897yezk62akq6W1ojg8FcO/L+9+CGh2uqT/79FOgA/K/jnNPSymQvH0SFrsofk lUECs9TuKmu0eVrJPyHBJCRD2QCftMUVdabZSa2Av7cEd768jI4D3vovWc5ERKqR9G/u0aiegH5K9 52+FkVDcmu0x4CgNdqlv4vOEfEdpNl2HKMVYVg2RpgRhq2ms4ynV2OqVoTCItdvUUd+tzhfYBC9Uo MiprIQhi5zjeRINyHTxtx2iB3LEjG9qSvJj9ezG7slNfXZtQcsZVq/Oe/bhEF1wpY3/tcqyC8xB8Y gH5ZxXlw==; Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0w77-00039A-7S; Mon, 04 Mar 2019 22:31:15 +0000 X-Originating-IP: 90.5.42.199 Received: from localhost.localdomain (atoulouse-657-1-1088-199.w90-5.abo.wanadoo.fr [90.5.42.199]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B7269240008; Mon, 4 Mar 2019 22:30:47 +0000 (UTC) From: Miquel Raynal To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Tudor Ambarus Subject: [PATCH v2 23/36] mtd: nand: ecc: Let the software BCH ECC engine be a module Date: Mon, 4 Mar 2019 23:28:28 +0100 Message-Id: <20190304222841.13899-24-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190304222841.13899-1-miquel.raynal@bootlin.com> References: <20190304222841.13899-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_223113_290768_AB570935 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh R , Tudor Ambarus , Julien Su , Schrempf Frieder , Paul Cercueil , linux-mtd@lists.infradead.org, Thomas Petazzoni , Miquel Raynal , Mason Yang , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There is no reason to prevent the software BCH ECC engine implementation to be compiled as a module, so change the 'bool' into a 'tristate'. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/ecc/Kconfig | 6 +++++- include/linux/mtd/nand-ecc-sw-bch.h | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/ecc/Kconfig b/drivers/mtd/nand/ecc/Kconfig index 7be48a7efda0..a9ab9bab252c 100644 --- a/drivers/mtd/nand/ecc/Kconfig +++ b/drivers/mtd/nand/ecc/Kconfig @@ -15,7 +15,7 @@ config MTD_NAND_ECC_SW_HAMMING_SMC The original Linux implementation had byte 0 and 1 swapped. config MTD_NAND_ECC_SW_BCH - bool "Software BCH ECC engine" + tristate "Software BCH ECC engine" select BCH select MTD_NAND_ECC default n @@ -25,4 +25,8 @@ config MTD_NAND_ECC_SW_BCH ECC codes. They are used with NAND devices requiring more than 1 bit of error correction. + If you are booting from NAND and need the BCH engine in order to mount + your filesystem, then do not select =m for this option unless you have + an initramfs. + endmenu diff --git a/include/linux/mtd/nand-ecc-sw-bch.h b/include/linux/mtd/nand-ecc-sw-bch.h index 509723870fc8..e72f781829c8 100644 --- a/include/linux/mtd/nand-ecc-sw-bch.h +++ b/include/linux/mtd/nand-ecc-sw-bch.h @@ -33,7 +33,7 @@ struct nand_ecc_sw_bch_conf { unsigned char *eccmask; }; -#if defined(CONFIG_MTD_NAND_ECC_SW_BCH) +#if IS_REACHABLE(CONFIG_MTD_NAND_ECC_SW_BCH) int nand_ecc_sw_bch_calculate(struct nand_device *nand, const unsigned char *buf, unsigned char *code);