| Message ID | 20190304222841.13899-4-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce the generic ECC engine abstraction | expand |
On Mon, 4 Mar 2019 23:28:08 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Both oneNAND and raw NAND bits can be compiled if MTD is enabled ^ OneNAND ^ can't ^ disabled > because of the if/endif logic in drivers/mtd/Kconfig. There is no need > for an extra "depends on MTD" in their respective Kconfig files. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> With this addressed Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/mtd/nand/onenand/Kconfig | 1 - > drivers/mtd/nand/raw/Kconfig | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/onenand/Kconfig b/drivers/mtd/nand/onenand/Kconfig > index 9dc15748947b..c168f3b4b296 100644 > --- a/drivers/mtd/nand/onenand/Kconfig > +++ b/drivers/mtd/nand/onenand/Kconfig > @@ -1,6 +1,5 @@ > menuconfig MTD_ONENAND > tristate "OneNAND Device Support" > - depends on MTD > depends on HAS_IOMEM > help > This enables support for accessing all type of OneNAND flash > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index 510a6b32820d..ebb8a3da9fa5 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -11,7 +11,6 @@ config MTD_NAND_ECC_SW_HAMMING_SMC > > menuconfig MTD_RAW_NAND > tristate "Raw/Parallel NAND Device Support" > - depends on MTD > select MTD_NAND_ECC_SW_HAMMING > help > This enables support for accessing all type of raw/parallel
diff --git a/drivers/mtd/nand/onenand/Kconfig b/drivers/mtd/nand/onenand/Kconfig index 9dc15748947b..c168f3b4b296 100644 --- a/drivers/mtd/nand/onenand/Kconfig +++ b/drivers/mtd/nand/onenand/Kconfig @@ -1,6 +1,5 @@ menuconfig MTD_ONENAND tristate "OneNAND Device Support" - depends on MTD depends on HAS_IOMEM help This enables support for accessing all type of OneNAND flash diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index 510a6b32820d..ebb8a3da9fa5 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -11,7 +11,6 @@ config MTD_NAND_ECC_SW_HAMMING_SMC menuconfig MTD_RAW_NAND tristate "Raw/Parallel NAND Device Support" - depends on MTD select MTD_NAND_ECC_SW_HAMMING help This enables support for accessing all type of raw/parallel
Both oneNAND and raw NAND bits can be compiled if MTD is enabled because of the if/endif logic in drivers/mtd/Kconfig. There is no need for an extra "depends on MTD" in their respective Kconfig files. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/onenand/Kconfig | 1 - drivers/mtd/nand/raw/Kconfig | 1 - 2 files changed, 2 deletions(-)