diff mbox series

mfd: axp20x: Allow the AXP223 to be probed by i2c

Message ID 20190318125548.24851-1-maxime.ripard@bootlin.com (mailing list archive)
State Mainlined, archived
Commit 4f799e47adb35e1e0e7a598eb856f3ac6c18b4aa
Headers show
Series mfd: axp20x: Allow the AXP223 to be probed by i2c | expand

Commit Message

Maxime Ripard March 18, 2019, 12:55 p.m. UTC
The AXP223 can be used both using the RSB proprietary bus, or a more
traditional I2C bus. The RSB is a faster bus and provides more features
(like some integrity checks on the messages), so it's usually preferrable
to use it, but since it's proprietary, when we want to use the PMIC in a
multi-master setup, the i2c might make sense as well.

Let's add that possibility.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/mfd/axp20x-i2c.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chen-Yu Tsai March 22, 2019, 8:53 a.m. UTC | #1
On Mon, Mar 18, 2019 at 8:55 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The AXP223 can be used both using the RSB proprietary bus, or a more
> traditional I2C bus. The RSB is a faster bus and provides more features
> (like some integrity checks on the messages), so it's usually preferrable
> to use it, but since it's proprietary, when we want to use the PMIC in a
> multi-master setup, the i2c might make sense as well.
>
> Let's add that possibility.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>
Lee Jones April 2, 2019, 7:01 a.m. UTC | #2
On Mon, 18 Mar 2019, Maxime Ripard wrote:

> The AXP223 can be used both using the RSB proprietary bus, or a more
> traditional I2C bus. The RSB is a faster bus and provides more features
> (like some integrity checks on the messages), so it's usually preferrable
> to use it, but since it's proprietary, when we want to use the PMIC in a
> multi-master setup, the i2c might make sense as well.
> 
> Let's add that possibility.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  drivers/mfd/axp20x-i2c.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
index a7b7c5423ea5..c2e8a0dee7f8 100644
--- a/drivers/mfd/axp20x-i2c.c
+++ b/drivers/mfd/axp20x-i2c.c
@@ -65,6 +65,7 @@  static const struct of_device_id axp20x_i2c_of_match[] = {
 	{ .compatible = "x-powers,axp202", .data = (void *)AXP202_ID },
 	{ .compatible = "x-powers,axp209", .data = (void *)AXP209_ID },
 	{ .compatible = "x-powers,axp221", .data = (void *)AXP221_ID },
+	{ .compatible = "x-powers,axp223", .data = (void *)AXP223_ID },
 	{ .compatible = "x-powers,axp806", .data = (void *)AXP806_ID },
 	{ },
 };
@@ -75,6 +76,7 @@  static const struct i2c_device_id axp20x_i2c_id[] = {
 	{ "axp202", 0 },
 	{ "axp209", 0 },
 	{ "axp221", 0 },
+	{ "axp223", 0 },
 	{ "axp806", 0 },
 	{ },
 };