From patchwork Mon Mar 18 15:31:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10857889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B622814DE for ; Mon, 18 Mar 2019 15:31:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96B50293A9 for ; Mon, 18 Mar 2019 15:31:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AEB92937B; Mon, 18 Mar 2019 15:31:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 370172937B for ; Mon, 18 Mar 2019 15:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=fQVPD9kELfiLkg6YBZaslxw7ecKok3sEm3BELbnwgUE=; b=B3hBDF+sJo/oop JzQ3SLN1x9sRaON+/VvvOYAHg8gIYDBwku27k2mGd2+B9o+oD/TPcWDprplAThi6EejtrtyygGW+h x+zmRjL4R9MMdwGyzDkiwI9qYqrSpS6Rp2Xpe43BSrqbaakcxdx4AOtRVe34fPrKDJgQzHzVfrIHp Kx66IwkumSgdZmuTptfVsnPnG5lgq6f2nUbV5aX46ni6/n68P4PbDIpJIQXinttFkHBz//3skxq8o JsVg7r9tJZdQrACvbz++zKDxS35oTGRfncMdrah9ynzM+BeOQgQzRoUCg6cpztAuiI3ErSr6lkuVv ugjOXJuW8WuG87ta5jTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5uEd-0006xp-5U; Mon, 18 Mar 2019 15:31:31 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5uEa-0006xM-Cs for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 15:31:29 +0000 Received: by mail-lj1-x243.google.com with SMTP id j89so3014513ljb.1 for ; Mon, 18 Mar 2019 08:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YJ45sQhZxlzNhYSORQHuDBBnr/6D4s+sX1io0WU/dG8=; b=tQAQqQ05r+JLMH7oOQNdf4jdgwfrcWhVAmnP/fOZrOpiKnEoMiYaEO2g0+wkMYolDH V27QDBQ4a3Cq43MbnXNNAEpJ4UYeFoUyC+CBJGbNk3i4P5UQV9cPgb9dryMo7rFJuJ45 apoK16hKbSNR2E9GU3+vmVREvo0E2LDNYJ0TZJYfeJcp9llot7g23Yp7L/FxK8Y2LeRZ bBCmX7SB8q8mYi6IApeKPaTxsDGuqTcCDu93RxVAdKaPeIV3xqVXnjKZK7UZFkc+VPXT kJIOQeJ65ObjZiWz5I3hL1dsE1XJA9ptXRoJoJm0hhdbgAQR8bYh2ex2PN0xuOSk9vEH dQKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YJ45sQhZxlzNhYSORQHuDBBnr/6D4s+sX1io0WU/dG8=; b=TUtiEwSoHtA6QQWEt+GSS76zSPvd1zaY+DG7cEknPY9GjOx0ZTmliqdxgmSGYEeJGr yq0OmCuJTgw1G7911HXnduKGqzodgy5Blmou1Fp1e1f0RAMlzegmIQDq6ccVz5IRoXF1 x2OyMxPoAwNtpXfzw45/P59CriZcnOJoynOKJa/EvET488Wdpk9Qt/gJgU+Wv6MSBc+N UJbiE0KJZADKPXIENg6+ZfYDPwMp96XwI6yVKs28msd+F+/IVb1O2eOiPSiQOtPCNRDK sJbDgdQrx8/vc1ugE6R1jRQhXgQjyP4h0ksB60pQkYQK4JC6zT2QsqFJ2UDoialJcblW 0JLw== X-Gm-Message-State: APjAAAU1FsSoC9MrdGiIbuJidfOOU4wdJnNipG35oWMUZlclz8PGL2px muPZTYDa/o3AOFOr+4GHA7E1+Q== X-Google-Smtp-Source: APXvYqzW0aoH9jR3Qte5pDfeS/xTufa19h4hIKCZ0bum69+KJOecywkmLsMh0nUT09RC0MykNSVZtg== X-Received: by 2002:a2e:20b:: with SMTP id 11mr11090763ljc.41.1552923086493; Mon, 18 Mar 2019 08:31:26 -0700 (PDT) Received: from linux.local (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id q2sm2163861lfa.63.2019.03.18.08.31.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 08:31:25 -0700 (PDT) From: Linus Walleij To: arm@kernel.org Subject: [PATCH] ARM: dts: nomadik: Fix polarity of SPI CS Date: Mon, 18 Mar 2019 16:31:22 +0100 Message-Id: <20190318153122.10257-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_083128_446379_047AC2B0 X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The SPI DT bindings are for historical reasons a pitfall, the ability to flag a GPIO line as active high/low with the second cell flags was introduced later so the SPI subsystem will only accept the bool flag spi-cs-high to indicate that the line is active high. It worked by mistake, but the mistake was corrected in another commit. The comment in the DTS file was also misleading: this CS is indeed active high. Fixes: cffbb02dafa3 ("ARM: dts: nomadik: Augment NHK15 panel setting") Signed-off-by: Linus Walleij --- ARM SoC people: please apply this directly for fixes if you're OK with it. --- arch/arm/boot/dts/ste-nomadik-nhk15.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/ste-nomadik-nhk15.dts b/arch/arm/boot/dts/ste-nomadik-nhk15.dts index 04066f9cb8a3..f2f6558a00f1 100644 --- a/arch/arm/boot/dts/ste-nomadik-nhk15.dts +++ b/arch/arm/boot/dts/ste-nomadik-nhk15.dts @@ -213,12 +213,13 @@ gpio-sck = <&gpio0 5 GPIO_ACTIVE_HIGH>; gpio-mosi = <&gpio0 4 GPIO_ACTIVE_HIGH>; /* - * It's not actually active high, but the frameworks assume - * the polarity of the passed-in GPIO is "normal" (active - * high) then actively drives the line low to select the - * chip. + * This chipselect is active high. Just setting the flags + * to GPIO_ACTIVE_HIGH is not enough for the SPI DT bindings, + * it will be ignored, only the special "spi-cs-high" flag + * really counts. */ cs-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; + spi-cs-high; num-chipselects = <1>; /*