| Message ID | 20190321023122.21332-2-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | edc82a99437a93c36b0ae18eb6daac0097fc6bd3 |
| Headers | show |
| Series | minor fixes for perf cs-etm | expand |
On Wed, 20 Mar 2019 at 20:31, Yue Haibing <yuehaibing@huawei.com> wrote: > > From: YueHaibing <yuehaibing@huawei.com> > > intlist__findnew() doesn't uses ERR_PTR() as a return mechanism > so its callers shouldn't try to extract the error using PTR_ERR( > ret) from intlist__findnew(), make cs_etm__process_auxtrace_info > return -ENOMEM instead. > > Fixes: cd8bfd8c973e ("perf tools: Add processing of coresight metadata") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 1108049..fd7f1da 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -1908,7 +1908,7 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > > /* Something went wrong, no need to continue */ > if (!inode) { > - err = PTR_ERR(inode); > + err = -ENOMEM; > goto err_free_metadata; > } > > -- > 2.7.0 Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Arnaldo, please consider adding to your tally. > >
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 1108049..fd7f1da 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -1908,7 +1908,7 @@ int cs_etm__process_auxtrace_info(union perf_event *event, /* Something went wrong, no need to continue */ if (!inode) { - err = PTR_ERR(inode); + err = -ENOMEM; goto err_free_metadata; }