From patchwork Sat Mar 30 18:46:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 10878563 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 598CE15AC for ; Sat, 30 Mar 2019 18:46:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3863C28882 for ; Sat, 30 Mar 2019 18:46:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27E382892E; Sat, 30 Mar 2019 18:46:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9234828882 for ; Sat, 30 Mar 2019 18:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=tFobIfEgrpor1VDloKIGTC2dbeVayErckO339Qmgj8A=; b=SOAFLxH3T4Uz7L 3q0sh7n8ajS8WY79Q2Ndp5jm8aVyVzca+Ul6IqNsUT4Repq/yx2nbbY35SUTXozUs7HMmcl6Iyw/6 gVipg+Ynuz0x3JjVaJRRSo0/JeJFnTIwq0254pMejIL+PsS4DXerRZATFi/3XgiQnUjd7Tw0sJFGp +ZI2sReUyWSNW3AuK2FyUzQIzqZAVA2kW5w4adeEEjIdS6SXJaAE0iufxj8uGeUeT1YELfDssayr5 PcOB2YflL40ck7duppmajY3RtNfvuNu757AYFnq8KxBT0A7hpm4u/hV+B9Wmb5vwsgjXKOO8MUbow ZbLQOtYPBY2+cE7evCVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAJ0A-0002ON-G7; Sat, 30 Mar 2019 18:46:46 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAJ06-0002Ni-F5 for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2019 18:46:44 +0000 Received: by mail-wm1-f67.google.com with SMTP id o25so5840355wmf.5 for ; Sat, 30 Mar 2019 11:46:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mgzR/UO00hrwzwegx+/3pOLuebweelH9rTXvJw1XzrI=; b=a4mK3DJhVW/KFI8Fy/zJlAV0m8eHpcntSRneA7wENvjmaIDEEjdR/a6LRWMWJrRWKW s0bmUJYEvVTt1lnRn8r+qFdN/zo7TrsYQ5ql5sn6pIXkxKWWp/JLes5P9eFYINA8DzgU MCw1ebtpt3ldReLsVH0UaIt1nCdAFevifgBLKOvPrWXw3C8HrDYU4EpKVqq/U5wn2NYU S2bKkjwq/JlGxXnX8YW+xneBm1io3n/yRJxlKr12Kpu7XGbldVCt8/bjRYju3VdSyFFf qV+Y5/mOxJ3MtJytdswMEQ61xGY0F6vNwRKUi2w3oIl+1M5JaUDX/a8ZOrDulzUc0Mr3 5Ujw== X-Gm-Message-State: APjAAAU465O0Imaj7ptxHAHdoKK6ZfUZSA0jzk2oD4jas9sBLqF7D1cA PuklVJIiVjI6PqTDbRbU1bwV1IggD9w= X-Google-Smtp-Source: APXvYqxqzdBoUCZg9KlDWnsuJ4JrJaJeN6c2yioqoS2zfm+AfUd/9gvLE+k3ws9nn8EPPnnkhG+5pw== X-Received: by 2002:a1c:7e51:: with SMTP id z78mr7543481wmc.82.1553971600253; Sat, 30 Mar 2019 11:46:40 -0700 (PDT) Received: from raver.teknoraver.net (net-93-70-69-135.cust.vodafonedsl.it. [93.70.69.135]) by smtp.gmail.com with ESMTPSA id t15sm9363203wmt.2.2019.03.30.11.46.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Mar 2019 11:46:39 -0700 (PDT) From: Matteo Croce To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64/vdso: don't leak kernel addresses Date: Sat, 30 Mar 2019 19:46:38 +0100 Message-Id: <20190330184638.16219-1-mcroce@redhat.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190330_114642_507288_C0327159 X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), two obfuscated kernel pointer are printed at every boot: vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____)) Remove the addresses from the print, which turns into a more discrete: vdso: 2 pages (1 code, 1 data) Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p") Signed-off-by: Matteo Croce Reviewed-by: Mukesh Ojha Acked-by: Mark Rutland --- arch/arm64/kernel/vdso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c index 2d419006ad43..fdfee0ef5bc5 100644 --- a/arch/arm64/kernel/vdso.c +++ b/arch/arm64/kernel/vdso.c @@ -146,8 +146,8 @@ static int __init vdso_init(void) } vdso_pages = (vdso_end - vdso_start) >> PAGE_SHIFT; - pr_info("vdso: %ld pages (%ld code @ %p, %ld data @ %p)\n", - vdso_pages + 1, vdso_pages, vdso_start, 1L, vdso_data); + pr_info("vdso: %ld pages (%ld code, %ld data)\n", + vdso_pages + 1, vdso_pages, 1L); /* Allocate the vDSO pagelist, plus a page for the data. */ vdso_pagelist = kcalloc(vdso_pages + 1, sizeof(struct page *),