From patchwork Mon Apr 1 04:25:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10879063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C167139A for ; Mon, 1 Apr 2019 04:26:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 119D1287B6 for ; Mon, 1 Apr 2019 04:26:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 059962881E; Mon, 1 Apr 2019 04:26:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AA392287B6 for ; Mon, 1 Apr 2019 04:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8zozwoBxG2uxGFh7GiJI05hbB5neePGiLV4xjsepH4s=; b=mAorbW3VPy8D/5 wpuOsackIB1FPWp4XqK/aD1y+3rpzu3MbZdwbNqep+gC1rUUajtsSGijGnwtrBoYp1WPI6AgbUqn+ 5XJs3/JjMa+uhBlBTrAySjRru9FAGsUIc9lRXNFpfzTeYR8lTEjBChBtW6mrUjGJzek04P9/WiI1G gJwkjrkMGXgPgvErJnHOL3oKtoh5bf5dphncIPtqPXhACZQd0goGil+8WGgg+PeJ9UVWzOKk7xTzF 722ZjSJMzz/hbHekfT2nLszkM/O0Vh5rMCw+NDIrjz0RB5nV18Pv2ZO3pkX8ZTBz7uMPe+nFc0iK2 SF1/YuIinA+3lnpem6Lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAoWh-0003sw-SN; Mon, 01 Apr 2019 04:26:27 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAoWJ-0003OG-3h for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 04:26:05 +0000 Received: by mail-pl1-x644.google.com with SMTP id y6so3807179pll.13 for ; Sun, 31 Mar 2019 21:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F8oXQCp56ZlNvc+eSoHWKahah7TDd6mimNeNhGWIK+s=; b=rtN8s57WRffcMH2IkFTtr1Iyk6C/knJjziPcbblRi7bEaR8VImlr9xv+6B7m8lirKO 0E6M/XRUApMMrh5uFLpCnBY77gNftJI9LjuZWKMIMHOaI5O6MaV/z2EPQfbRrTyxN9Vp 9Ncxm5qRGhZWyYPHq3VurGOlbpWWjhHWxxr9W6RDzv/7hnv/ZMKJyiGF1fOKvotv9dN5 jLqo3HymvrGMTsEeQvA0+CBQN617c1Ps9cTfzXDWMdVLNNrwUdpk/ddkD7JwE9Kp3mfI y3BgoOqpdkpLbTq+zIkZ7FK58QvC2iXJp10siqkwGayR/jKuObnSJxPRf5vhopch4jeb Cqvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F8oXQCp56ZlNvc+eSoHWKahah7TDd6mimNeNhGWIK+s=; b=olcufEc/o3G5zoIrSD5i8gJXeh0Kv5k7US7gi4Edgtw2wXI+2NqPGH6fHi3hGt/O2A MFkLLJERS3cLesxGmut1J4t50O8u3mGuodq7Dpy1juKyC1IkLLzYJPdhyodRHRlBduk9 o85k1zP3wH71p/u+3o7FyDeM6fbo+Rb8nIAIsdzG1C+LiAkYXon9fSn5G2bfgFFtsduV IWox+tfDFRsa6X1w682l4+ZuB32dfHk8CjPaXyEszSSATg23Gpf7nkwgDAi5tsJ3YikE rpqHroxoILYdxNHn9Dm0d64bl3gHQJfOx0ewbTfyJRhcP2TnEajHIt81C62EscR0RZ0z +vNg== X-Gm-Message-State: APjAAAX5wyD1+MG/aS3x+65yWhMg1V+zImC0+XEr0Abfcsct1EjSQySs CrnHI8wOBvj55hd5VffI7bI= X-Google-Smtp-Source: APXvYqxsOciJD3nXK9tfj+BsoGE2REapwqP7u/Wjlo23MzmgnpD2lRXHzbHjJ+F3JxqG9Hv28f/NGQ== X-Received: by 2002:a17:902:8349:: with SMTP id z9mr41663324pln.144.1554092762162; Sun, 31 Mar 2019 21:26:02 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id t22sm10996829pgu.45.2019.03.31.21.26.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Mar 2019 21:26:01 -0700 (PDT) From: Andrey Smirnov To: linux-pci@vger.kernel.org Subject: [PATCH v3 02/11] PCI: imx6: Remove redundant debug tracing Date: Sun, 31 Mar 2019 21:25:38 -0700 Message-Id: <20190401042547.14067-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190401042547.14067-1-andrew.smirnov@gmail.com> References: <20190401042547.14067-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_212603_281297_3FD52002 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , Lorenzo Pieralisi , Richard Zhu , linux-arm-kernel@lists.infradead.org, Andrey Smirnov , linux-kernel@vger.kernel.org, Fabio Estevam , linux-imx@nxp.com, Bjorn Helgaas , Leonard Crestez , Chris Healy , Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP All calls to imx6_pcie_wait_for_link() share the same error path and the state of PHY debug registers will already be printed there. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org Signed-off-by: Andrey Smirnov --- drivers/pci/controller/dwc/pci-imx6.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index fb0b29e5b1f0..7582d0b2fbe7 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -726,16 +726,9 @@ static int imx6_setup_phy_mpll(struct imx6_pcie *imx6_pcie) static int imx6_pcie_wait_for_link(struct imx6_pcie *imx6_pcie) { struct dw_pcie *pci = imx6_pcie->pci; - struct device *dev = pci->dev; /* check if the link is up or not */ - if (!dw_pcie_wait_for_link(pci)) - return 0; - - dev_dbg(dev, "DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n", - dw_pcie_readl_dbi(pci, PCIE_PHY_DEBUG_R0), - dw_pcie_readl_dbi(pci, PCIE_PHY_DEBUG_R1)); - return -ETIMEDOUT; + return dw_pcie_wait_for_link(pci); } static int imx6_pcie_wait_for_speed_change(struct imx6_pcie *imx6_pcie)