From patchwork Mon Apr 1 16:51:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10880313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 52A1317E1 for ; Mon, 1 Apr 2019 16:53:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 376FE2864E for ; Mon, 1 Apr 2019 16:53:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B1872868C; Mon, 1 Apr 2019 16:53:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD5AB2864E for ; Mon, 1 Apr 2019 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9E+a6j1ACiCq65REpth6efQdXvqa/81PzDFaFbZ0Fis=; b=iEcRvKo4I3xUGG RitOsMRGw+IpYPuFPjThU9YOvd2ir28H5LxwAJd00JTx//bNNQus2PZ3LVyZH6SWcMHkX5UkNflxY BNNre5iUju8cG381MXxWzRgyNjcNTlzNwpS4oe9ZN1MRZ7VrPtcU+lmG5Ux3HIyApPtBHuowVrXsb xVUwxzGhuaUJYlyRc+a1M1jSV/NR/VtJ1fH6xoiiYkR4Yj0PDpctIfeaXkKXfl8/EbvvO8umXROTo AbIK0wzbKgVOdig753PdoNysLLLEKorvvjfJWtqFsmI2ZuG2M4y6+HY9BHvPVzTMKJnS8HwKYg0x7 dnhfs8RhcPkaMOIhpxRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0Bk-0001Hy-Rp; Mon, 01 Apr 2019 16:53:36 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0BA-0000Td-2J for linux-arm-kernel@bombadil.infradead.org; Mon, 01 Apr 2019 16:53:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aWQZnFQ1TXyGKcVlgRF/fopxDUO16H8z+1OffJ5A3lA=; b=NP5dl3jP+x+O3RbRkNZx0CU8/p AfL2qPmyw789aiy39zbo5DNjLeWPlNL2YpDeq/Rh0O0BXA0pjZY2EkhXpDrbxtitAh2F6L4HEgKtg OVFFAqkxCN/a9pLSo9+jcyXCqYnI98BAKS7gwX915wbH6Lg5v0KyyNN05/q+ViZ5m2Tumwc9Glahb itcKgLVTlQf/c39UlmeXvfADWZ0Aahhj5e82fw5m9MnVFdGT1Vvu2PlGIX3EQMf8B61StztoKL9ZR A4V/wX+LZgDnNv8R1T7XCddKG7MHo/b6R9Grx8l67UrZowlPQc4SiXsMSAxiAx65mbhw64Nxg6FfB TTZMfaWA==; Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0B6-000309-Gp for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 16:52:58 +0000 X-Originating-IP: 81.185.163.178 Received: from localhost.localdomain (178.163.185.81.rev.sfr.net [81.185.163.178]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id DE6EB24000D; Mon, 1 Apr 2019 16:52:28 +0000 (UTC) From: Miquel Raynal To: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Kishon Vijay Abraham I Subject: [PATCH 11/15] phy: mvebu-cp110-comphy: Update comment about powering off all lanes at boot Date: Mon, 1 Apr 2019 18:51:27 +0200 Message-Id: <20190401165131.23370-12-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190401165131.23370-1-miquel.raynal@bootlin.com> References: <20190401165131.23370-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_125257_280154_A7176BC7 X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Antoine Tenart , Russell King , Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , Miquel Raynal , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Now that all COMPHY modes are supported by the driver, update the comment stating that mvebu_comphy_power_off() should be called for each lane. This is still wrong because for compatibility reasons, it might break users running an old firmware (the driver only uses SMC calls for SATA, USB and PCIe configuration, there is no code in Linux to fallback on in these cases. Signed-off-by: Miquel Raynal --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c index d66412b38ff7..6f6c26c1c622 100644 --- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c +++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c @@ -841,9 +841,11 @@ static int mvebu_comphy_probe(struct platform_device *pdev) phy_set_drvdata(phy, lane); /* - * Once all modes are supported in this driver we should call + * All modes are supported in this driver so we could call * mvebu_comphy_power_off(phy) here to avoid relying on the - * bootloader/firmware configuration. + * bootloader/firmware configuration, but for compatibility + * reasons we cannot de-configure the COMPHY without being sure + * that the firmware is up-to-date and fully-featured. */ }