| Message ID | 20190411102633.3685-2-mcroce@redhat.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 5ee15c101f29e0093ffb5448773ccbc786eb313b |
| Headers | show |
| Series | Fix thunderx MTU with XDP | expand |
On Thu, 11 Apr 2019 12:26:32 +0200 Matteo Croce <mcroce@redhat.com> wrote: > The thunderx driver splits frames bigger than 1530 bytes to multiple > pages, making impossible to run an eBPF program on it. > This leads to a maximum MTU of 1508 if QinQ is in use. > > The thunderx driver forbids to load an eBPF program if the MTU is higher > than 1500 bytes. Raise the limit to 1508 so it is possible to use L2 > protocols which need some more headroom. > > Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support") > Signed-off-by: Matteo Croce <mcroce@redhat.com> > --- > drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) LGTM Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c index 28eac9056211..debc8c861c6b 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c @@ -32,6 +32,13 @@ #define DRV_NAME "nicvf" #define DRV_VERSION "1.0" +/* NOTE: Packets bigger than 1530 are split across multiple pages and XDP needs + * the buffer to be contiguous. Allow XDP to be set up only if we don't exceed + * this value, keeping headroom for the 14 byte Ethernet header and two + * VLAN tags (for QinQ) + */ +#define MAX_XDP_MTU (1530 - ETH_HLEN - VLAN_HLEN * 2) + /* Supported devices */ static const struct pci_device_id nicvf_id_table[] = { { PCI_DEVICE_SUB(PCI_VENDOR_ID_CAVIUM, @@ -1830,8 +1837,10 @@ static int nicvf_xdp_setup(struct nicvf *nic, struct bpf_prog *prog) bool bpf_attached = false; int ret = 0; - /* For now just support only the usual MTU sized frames */ - if (prog && (dev->mtu > 1500)) { + /* For now just support only the usual MTU sized frames, + * plus some headroom for VLAN, QinQ. + */ + if (prog && dev->mtu > MAX_XDP_MTU) { netdev_warn(dev, "Jumbo frames not yet supported with XDP, current MTU %d.\n", dev->mtu); return -EOPNOTSUPP;
The thunderx driver splits frames bigger than 1530 bytes to multiple pages, making impossible to run an eBPF program on it. This leads to a maximum MTU of 1508 if QinQ is in use. The thunderx driver forbids to load an eBPF program if the MTU is higher than 1500 bytes. Raise the limit to 1508 so it is possible to use L2 protocols which need some more headroom. Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support") Signed-off-by: Matteo Croce <mcroce@redhat.com> --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)