| Message ID | 20190414191450.18377-2-andradanciu1997@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | ac097cac496f69e97083c6b128c5a209a85c6fcb |
| Headers | show |
| Series | Fix invalid license IDS | expand |
On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu <andradanciu1997@gmail.com> wrote: > > As the file had no other license notice/reference, it falls under the > project license and therefore the proper SPDX id is: GPL-2.0-only > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier") > Reported-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Andra Danciu <andradanciu1997@gmail.com> > --- > sound/soc/fsl/mpc5200_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c > index 4396442c2fdd..ccf9301889fe 100644 > --- a/sound/soc/fsl/mpc5200_dma.c > +++ b/sound/soc/fsl/mpc5200_dma.c > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL > +// SPDX-License-Identifier: GPL-2.0-only According to Documentation/process/license-rules.rst this should be: // SPDX-License-Identifier: GPL-2.0
On Sun, 14 Apr 2019, Fabio Estevam wrote: > On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu <andradanciu1997@gmail.com> wrote: > > > > As the file had no other license notice/reference, it falls under the > > project license and therefore the proper SPDX id is: GPL-2.0-only > > > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > > Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier") > > Reported-by: Thomas Gleixner <tglx@linutronix.de> > > Signed-off-by: Andra Danciu <andradanciu1997@gmail.com> > > --- > > sound/soc/fsl/mpc5200_dma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c > > index 4396442c2fdd..ccf9301889fe 100644 > > --- a/sound/soc/fsl/mpc5200_dma.c > > +++ b/sound/soc/fsl/mpc5200_dma.c > > @@ -1,4 +1,4 @@ > > -// SPDX-License-Identifier: GPL > > +// SPDX-License-Identifier: GPL-2.0-only > > According to Documentation/process/license-rules.rst this should be: > > // SPDX-License-Identifier: GPL-2.0 Both are valid.
On Mon, Apr 15, 2019 at 12:53 AM Fabio Estevam <festevam@gmail.com> wrote: > > On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu <andradanciu1997@gmail.com> wrote: > > > > As the file had no other license notice/reference, it falls under the > > project license and therefore the proper SPDX id is: GPL-2.0-only > > > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > > Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier") > > Reported-by: Thomas Gleixner <tglx@linutronix.de> > > Signed-off-by: Andra Danciu <andradanciu1997@gmail.com> > > --- > > sound/soc/fsl/mpc5200_dma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c > > index 4396442c2fdd..ccf9301889fe 100644 > > --- a/sound/soc/fsl/mpc5200_dma.c > > +++ b/sound/soc/fsl/mpc5200_dma.c > > @@ -1,4 +1,4 @@ > > -// SPDX-License-Identifier: GPL > > +// SPDX-License-Identifier: GPL-2.0-only > > According to Documentation/process/license-rules.rst this should be: > > // SPDX-License-Identifier: GPL-2.0 Actually
On Mon, Apr 15, 2019 at 10:26 AM Daniel Baluta <daniel.baluta@gmail.com> wrote: > > On Mon, Apr 15, 2019 at 12:53 AM Fabio Estevam <festevam@gmail.com> wrote: > > > > On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu <andradanciu1997@gmail.com> wrote: > > > > > > As the file had no other license notice/reference, it falls under the > > > project license and therefore the proper SPDX id is: GPL-2.0-only > > > > > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > > > Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier") > > > Reported-by: Thomas Gleixner <tglx@linutronix.de> > > > Signed-off-by: Andra Danciu <andradanciu1997@gmail.com> > > > --- > > > sound/soc/fsl/mpc5200_dma.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c > > > index 4396442c2fdd..ccf9301889fe 100644 > > > --- a/sound/soc/fsl/mpc5200_dma.c > > > +++ b/sound/soc/fsl/mpc5200_dma.c > > > @@ -1,4 +1,4 @@ > > > -// SPDX-License-Identifier: GPL > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > According to Documentation/process/license-rules.rst this should be: > > > > // SPDX-License-Identifier: GPL-2.0 > Actually, according to https://spdx.org/licenses/GPL-2.0-only.html GPL-2.0 is another name for GPL-2.0-only
On Mon, 15 Apr 2019, Daniel Baluta wrote: > On Mon, Apr 15, 2019 at 10:26 AM Daniel Baluta <daniel.baluta@gmail.com> wrote: > > On Mon, Apr 15, 2019 at 12:53 AM Fabio Estevam <festevam@gmail.com> wrote: > > > On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu <andradanciu1997@gmail.com> wrote: > > > > -// SPDX-License-Identifier: GPL > > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > > > According to Documentation/process/license-rules.rst this should be: > > > > > > // SPDX-License-Identifier: GPL-2.0 > > > > Actually, according to > > https://spdx.org/licenses/GPL-2.0-only.html > > GPL-2.0 is another name for GPL-2.0-only See also: LICENSES/preferred/GPL-2.0 Valid-License-Identifier: GPL-2.0 Valid-License-Identifier: GPL-2.0-only If the identifier would be invalid, scripts/spdxcheck.py would complain ... Thanks, tglx
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c index 4396442c2fdd..ccf9301889fe 100644 --- a/sound/soc/fsl/mpc5200_dma.c +++ b/sound/soc/fsl/mpc5200_dma.c @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL +// SPDX-License-Identifier: GPL-2.0-only // // Freescale MPC5200 PSC DMA // ALSA SoC Platform driver
As the file had no other license notice/reference, it falls under the project license and therefore the proper SPDX id is: GPL-2.0-only Cc: Daniel Baluta <daniel.baluta@nxp.com> Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier") Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andra Danciu <andradanciu1997@gmail.com> --- sound/soc/fsl/mpc5200_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)