From patchwork Sun Apr 14 21:02:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alyssa Rosenzweig X-Patchwork-Id: 10899973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D6A313B5 for ; Sun, 14 Apr 2019 21:02:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23EB22888C for ; Sun, 14 Apr 2019 21:02:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 173E328893; Sun, 14 Apr 2019 21:02:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C0A382888C for ; Sun, 14 Apr 2019 21:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Qr9lcdhsRUhQtJP2Qf4ZPuQ3V+0roSTgxrOfBAzlIUg=; b=SKeIlJgdOEcczI 10Kns9hGUfbbyloJe+mjAg9vpJy/v7ezqC1hlKCoWjBcQj42F96E5D+kmtjq/XskFMU3Kmg4rtLDq LP4nmuhBchhzCVh/BpQPeWNxXmWelHaEFF0lmPtMqZTBKlb6SpGmBjnwXub+Gty2XjtgRcjtc0Vyl mXzjOsi9bXxUzCWh+NyCT8TFlHFlZ9IccnDeD2CYBfUw+7rZIuX8EUuGxVwjffF7AKinLFbvYBFn5 IHMjGBfVzv8YAVWea7OaoomICcCwEdcvmZ0v2wAd3sKAKRZaHVn5eLUUx5C6nsWIzgX3CFWoY07Gg E2KDOVMNA68xgyunhuLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFmGb-0006H4-6U; Sun, 14 Apr 2019 21:02:21 +0000 Received: from rosenzweig.io ([107.170.207.86]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFmGX-0006GN-Af; Sun, 14 Apr 2019 21:02:18 +0000 From: Alyssa Rosenzweig To: linux-rockchip@lists.infradead.org Subject: [PATCH] ASoC: rockchip: Select DMA_PL330 by RK3399 audio Date: Sun, 14 Apr 2019 14:02:12 -0700 Message-Id: <20190414210212.2144-1-alyssa@rosenzweig.io> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190414_140217_371045_4D39E079 X-CRM114-Status: UNSURE ( 6.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Heiko Stuebner , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Mark Brown , linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Without the appropriate DMA controller selected, the RK3399 audio drivers compile but fail immediately. Accordingly, selecting the RK3399 audio without the corresponding PL330 controller is an invalid configuration. Prevent errors (otherwise forcing the driver to unload at runtime) by an appropriate `select` directive in the Kconfig. Signed-off-by: Alyssa Rosenzweig Cc: Heiko Stuebner Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/soc/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 957046ac6c8c..fa3cab461a60 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -73,6 +73,7 @@ config SND_SOC_RK3399_GRU_SOUND select SND_SOC_RT5514_SPI select SND_SOC_HDMI_CODEC select SND_SOC_DMIC + select PL330_DMA help Say Y or M here if you want to add support multiple codecs for SoC audio on Rockchip RK3399 GRU boards.