diff mbox series

[-next] regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe()

Message ID 20190417023059.162828-1-weiyongjun1@huawei.com (mailing list archive)
State Mainlined, archived
Commit dc62f951a6a8490bcccc7b6de36cd85bd57be740
Headers show
Series [-next] regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe() | expand

Commit Message

Wei Yongjun April 17, 2019, 2:30 a.m. UTC 
In case of error, the function of_iomap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/regulator/stm32-pwr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
index e434b26d4c8b..d4b9d6accfad 100644
--- a/drivers/regulator/stm32-pwr.c
+++ b/drivers/regulator/stm32-pwr.c
@@ -140,9 +140,9 @@  static int stm32_pwr_regulator_probe(struct platform_device *pdev)
 	int i, ret = 0;
 
 	base = of_iomap(np, 0);
-	if (IS_ERR(base)) {
+	if (!base) {
 		dev_err(&pdev->dev, "Unable to map IO memory\n");
-		return PTR_ERR(base);
+		return -ENOMEM;
 	}
 
 	config.dev = &pdev->dev;