| Message ID | 20190502225336.206885-4-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] dt-bindings: drm/bridge/synopsys: dw-hdmi: Add "unwedge" for ddc bus | expand |
On Thu, May 02, 2019 at 03:53:35PM -0700, Douglas Anderson wrote: > This adds the "unwedge" pinctrl entries introduced by a recent dw_hdmi > change that can unwedge the dw_hdmi i2c bus in some cases. It's > expected that any boards using this would add: > > pinctrl-names = "default", "unwedge"; > pinctrl-0 = <&hdmi_ddc>; > pinctrl-1 = <&hdmi_ddc_unwedge>; > > Note that this isn't added by default because some boards may choose > to mux i2c5 for their DDC bus (if that is more tested for them). > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Sean Paul <sean@poorly.run> > --- > > arch/arm/boot/dts/rk3288.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 74c9517c4f92..eebc04fa1e4d 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -1545,6 +1545,15 @@ > rockchip,pins = <7 RK_PC3 2 &pcfg_pull_none>, > <7 RK_PC4 2 &pcfg_pull_none>; > }; > + > + hdmi_ddc_unwedge: hdmi-ddc-unwedge { > + rockchip,pins = <7 RK_PC3 RK_FUNC_GPIO &pcfg_output_low>, > + <7 RK_PC4 2 &pcfg_pull_none>; > + }; > + }; > + > + pcfg_output_low: pcfg-output-low { > + output-low; > }; > > pcfg_pull_up: pcfg-pull-up { > -- > 2.21.0.1020.gf2820cf01a-goog >
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 74c9517c4f92..eebc04fa1e4d 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -1545,6 +1545,15 @@ rockchip,pins = <7 RK_PC3 2 &pcfg_pull_none>, <7 RK_PC4 2 &pcfg_pull_none>; }; + + hdmi_ddc_unwedge: hdmi-ddc-unwedge { + rockchip,pins = <7 RK_PC3 RK_FUNC_GPIO &pcfg_output_low>, + <7 RK_PC4 2 &pcfg_pull_none>; + }; + }; + + pcfg_output_low: pcfg-output-low { + output-low; }; pcfg_pull_up: pcfg-pull-up {
This adds the "unwedge" pinctrl entries introduced by a recent dw_hdmi change that can unwedge the dw_hdmi i2c bus in some cases. It's expected that any boards using this would add: pinctrl-names = "default", "unwedge"; pinctrl-0 = <&hdmi_ddc>; pinctrl-1 = <&hdmi_ddc_unwedge>; Note that this isn't added by default because some boards may choose to mux i2c5 for their DDC bus (if that is more tested for them). Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm/boot/dts/rk3288.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)