| Message ID | 20190503155235.6414-2-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] ARM: dts: imx53: Update UART configuration on M53Menlo | expand |
Hi Marek, On Fri, May 3, 2019 at 12:52 PM Marek Vasut <marex@denx.de> wrote: > diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts > index 62bc6a95a477..46f990759660 100644 > --- a/arch/arm/boot/dts/imx53-m53menlo.dts > +++ b/arch/arm/boot/dts/imx53-m53menlo.dts > @@ -50,7 +50,7 @@ > regulator-name = "vbus"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > - gpio = <&gpio1 2 GPIO_ACTIVE_LOW>; > + gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>; If this GPIO controlled regulator is changed to active high, then it needs the 'enable-active-high' property.
On 5/3/19 6:16 PM, Fabio Estevam wrote: > Hi Marek, > > On Fri, May 3, 2019 at 12:52 PM Marek Vasut <marex@denx.de> wrote: > >> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts >> index 62bc6a95a477..46f990759660 100644 >> --- a/arch/arm/boot/dts/imx53-m53menlo.dts >> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts >> @@ -50,7 +50,7 @@ >> regulator-name = "vbus"; >> regulator-min-microvolt = <5000000>; >> regulator-max-microvolt = <5000000>; >> - gpio = <&gpio1 2 GPIO_ACTIVE_LOW>; >> + gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>; > > If this GPIO controlled regulator is changed to active high, then it > needs the 'enable-active-high' property. True, I should know ( 0e7d6f94016407fd7e1ae472e254d64d4454e9c8 ). Thanks
diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts index 62bc6a95a477..46f990759660 100644 --- a/arch/arm/boot/dts/imx53-m53menlo.dts +++ b/arch/arm/boot/dts/imx53-m53menlo.dts @@ -50,7 +50,7 @@ regulator-name = "vbus"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - gpio = <&gpio1 2 GPIO_ACTIVE_LOW>; + gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>; }; }; @@ -268,8 +268,10 @@ pinctrl_usb: usbgrp { fsl,pins = < - MX53_PAD_GPIO_2__GPIO1_2 0x1d5 - MX53_PAD_GPIO_3__USBOH3_USBH1_OC 0x1d5 + MX53_PAD_GPIO_2__GPIO1_2 0x1c4 + MX53_PAD_GPIO_3__USBOH3_USBH1_OC 0x1c4 + MX53_PAD_GPIO_4__GPIO1_4 0x1c4 + MX53_PAD_GPIO_18__GPIO7_13 0x1c4 >; }; }; @@ -322,7 +324,7 @@ pinctrl-0 = <&pinctrl_usb>; vbus-supply = <®_usbh1_vbus>; phy_type = "utmi"; - dr_mode = "peripheral"; + dr_mode = "host"; status = "okay"; };
Turn USBH1 into Host and update the GPIO polarity of the regulator to match new hardware. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> To: linux-arm-kernel@lists.infradead.org --- arch/arm/boot/dts/imx53-m53menlo.dts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)