| Message ID | 20190503155235.6414-3-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] ARM: dts: imx53: Update UART configuration on M53Menlo | expand |
On Fri, May 3, 2019 at 12:52 PM Marek Vasut <marex@denx.de> wrote: > > diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts > index 46f990759660..a4cd2c22fa9e 100644 > --- a/arch/arm/boot/dts/imx53-m53menlo.dts > +++ b/arch/arm/boot/dts/imx53-m53menlo.dts > @@ -86,6 +86,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_fec>; > phy-mode = "rmii"; > + phy-reset-gpios = <&gpio7 7 GPIO_ACTIVE_HIGH>; I suppose that this should be GPIO_ACTIVE_LOW instead. The FEC driver ignores the phy-reset-gpios polarity and it assumes active low unless the property 'phy-reset-active-high' is passed.
On 5/3/19 6:19 PM, Fabio Estevam wrote: > On Fri, May 3, 2019 at 12:52 PM Marek Vasut <marex@denx.de> wrote: >> >> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts >> index 46f990759660..a4cd2c22fa9e 100644 >> --- a/arch/arm/boot/dts/imx53-m53menlo.dts >> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts >> @@ -86,6 +86,7 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_fec>; >> phy-mode = "rmii"; >> + phy-reset-gpios = <&gpio7 7 GPIO_ACTIVE_HIGH>; > > I suppose that this should be GPIO_ACTIVE_LOW instead. > > The FEC driver ignores the phy-reset-gpios polarity and it assumes > active low unless the property 'phy-reset-active-high' is passed. I double-checked the schematic, yes, it should be active low. Thanks
diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts index 46f990759660..a4cd2c22fa9e 100644 --- a/arch/arm/boot/dts/imx53-m53menlo.dts +++ b/arch/arm/boot/dts/imx53-m53menlo.dts @@ -86,6 +86,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec>; phy-mode = "rmii"; + phy-reset-gpios = <&gpio7 7 GPIO_ACTIVE_HIGH>; status = "okay"; };
Add ethernet PHY GPIO reset line, to let the kernel to reset the PHY. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> To: linux-arm-kernel@lists.infradead.org --- arch/arm/boot/dts/imx53-m53menlo.dts | 1 + 1 file changed, 1 insertion(+)