From patchwork Sun May 5 21:31:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10930393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F91392A for ; Sun, 5 May 2019 21:31:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BA3E2864A for ; Sun, 5 May 2019 21:31:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6DE532865F; Sun, 5 May 2019 21:31:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 040342864A for ; Sun, 5 May 2019 21:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Lw3P/widz58A7BtMFsJLTpZdaJdRpCAdJeHFiB9ITe4=; b=XSucyXLAt0wurx b/dSAzvzNXSXsgG64NqH6neBjh59MaXDupU1Itv05uwwLwD0eySdmq2x+/YKkDDmgH28F9i0EnKqC 0OFTvh25LADlHSS8sS0EwA+dru3vZCU84zd8IYojrMHahNvLSCDjgfXEzKn0zhXMZMu7UKbFJar0H 08GK5PA0PQE7hWBf3WmGS2smpYgNMpHCoqTv7lJXTq26rNkuRqT/MDinSZj1yTuL42XpWIiCVJnLC ooXso16ApF6VvUnxdR4y6enOlNkuMhH5v6dodh+kI3sFeiUGxfRALXmO8nTlCfWb9c4nNE8B0ehmG q8n7EDyxO6tLvki62R5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNOjf-0001UH-3B; Sun, 05 May 2019 21:31:51 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNOjb-0001TM-H2; Sun, 05 May 2019 21:31:49 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hNOjQ-0007uz-Ax; Sun, 05 May 2019 21:31:36 +0000 From: Colin King To: Felix Fietkau , Roy Luo , Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH][next] mt76: fix less than zero check on a u8 variable Date: Sun, 5 May 2019 22:31:35 +0100 Message-Id: <20190505213135.3895-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190505_143147_702414_9F788890 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The signed return from the call to get_omac_idx is being assigned to the u8 variable mac_idx and then checked for a negative error condition which is always going to be false. Fix this by assigning the return to the int variable ret and checking this instead. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets") Signed-off-by: Colin Ian King --- drivers/net/wireless/mediatek/mt76/mt7615/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c index 80e6b211f60b..460d90d5ed6d 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c @@ -77,11 +77,12 @@ static int mt7615_add_interface(struct ieee80211_hw *hw, goto out; } - mvif->omac_idx = get_omac_idx(vif->type, dev->omac_mask); - if (mvif->omac_idx < 0) { + ret = get_omac_idx(vif->type, dev->omac_mask); + if (ret < 0) { ret = -ENOSPC; goto out; } + mvif->omac_idx = ret; /* TODO: DBDC support. Use band 0 and wmm 0 for now */ mvif->band_idx = 0;