| Message ID | 20190512114105.41792-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e6c4375f7c9293ffa65469d16f8ebd2586cb03f2 |
| Headers | show |
| Series | ARM: mm: remove unused variables | expand |
On Sun, May 12, 2019 at 1:48 PM YueHaibing <yuehaibing@huawei.com> wrote: > Fix gcc warnings: > > arch/arm/mm/init.c: In function 'mem_init': > arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable] > extern u32 itcm_end; > ^ > arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable] > extern u32 dtcm_end; > ^ > > They are not used any more since > commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout") Thanks! Sorry for missing that. > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Sun, 12 May 2019 at 13:51, YueHaibing <yuehaibing@huawei.com> wrote: > > Fix gcc warnings: > > arch/arm/mm/init.c: In function 'mem_init': > arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable] > extern u32 itcm_end; > ^ > arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable] > extern u32 dtcm_end; > ^ > > They are not used any more since > commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/arm/mm/init.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Did you submit it to Russell's patch system? Best regards, Krzysztof
On 2019/6/4 2:45, Krzysztof Kozlowski wrote: > On Sun, 12 May 2019 at 13:51, YueHaibing <yuehaibing@huawei.com> wrote: >> >> Fix gcc warnings: >> >> arch/arm/mm/init.c: In function 'mem_init': >> arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable] >> extern u32 itcm_end; >> ^ >> arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable] >> extern u32 dtcm_end; >> ^ >> >> They are not used any more since >> commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout") >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> arch/arm/mm/init.c | 6 ------ >> 1 file changed, 6 deletions(-) > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > Did you submit it to Russell's patch system? Thanks for your reminder, I will send it. > > Best regards, > Krzysztof > > . >
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index be0b429..c71ecbb 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -450,12 +450,6 @@ static void __init free_highpages(void) */ void __init mem_init(void) { -#ifdef CONFIG_HAVE_TCM - /* These pointers are filled in on TCM detection */ - extern u32 dtcm_end; - extern u32 itcm_end; -#endif - set_max_mapnr(pfn_to_page(max_pfn) - mem_map); /* this will put all unused low memory onto the freelists */
Fix gcc warnings: arch/arm/mm/init.c: In function 'mem_init': arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable] extern u32 itcm_end; ^ arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable] extern u32 dtcm_end; ^ They are not used any more since commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/arm/mm/init.c | 6 ------ 1 file changed, 6 deletions(-)