| Message ID | 20190515084925.30155-1-yinbo.zhu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] arm64: dts: ls1028a: Add esdhc node in dts | expand |
Hi, I just check mmc upstream code, that patch still not upstream. Please help merge it to upstream tree. Thanks Regards, Yinbo Zhu > -----Original Message----- > From: Yinbo Zhu [mailto:yinbo.zhu@nxp.com] > Sent: 2019年5月15日 16:49 > To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob > Herring <robh+dt@kernel.org> > Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Mark > Rutland <mark.rutland@arm.com>; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-mmc@vger.kernel.org; Y.b. Lu <yangbo.lu@nxp.com>; Jiafei Pan > <jiafei.pan@nxp.com>; Ashish Kumar <ashish.kumar@nxp.com> > Subject: [PATCH v3] arm64: dts: ls1028a: Add esdhc node in dts > > From: Ashish Kumar <Ashish.Kumar@nxp.com> > > This patch is to add esdhc node and enable SD UHS-I, eMMC HS200 for > ls1028ardb/ls1028aqds board. > > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com> > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com> > --- > Change in v3: > replace "esdhc@" with "mmc@" > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 ++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27 > +++++++++++++++++++++ > 3 files changed, 48 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index 14c79f4..180e5d2 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -42,6 +42,14 @@ > status = "okay"; > }; > > +&esdhc { > + status = "okay"; > +}; > + > +&esdhc1 { > + status = "okay"; > +}; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > index f86b054..1bfaf42 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > @@ -30,6 +30,19 @@ > }; > }; > > +&esdhc { > + status = "okay"; > + sd-uhs-sdr104; > + sd-uhs-sdr50; > + sd-uhs-sdr25; > + sd-uhs-sdr12; > + }; > + > +&esdhc1 { > + status = "okay"; > + mmc-hs200-1_8v; > + }; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbc..462833c 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -274,6 +274,33 @@ > status = "disabled"; > }; > > + esdhc: mmc@2140000 { > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2140000 0x0 0x10000>; > + interrupts = <0 28 0x4>; /* Level high type */ > + clock-frequency = <0>; /* fixed up by bootloader */ > + clocks = <&clockgen 2 1>; > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + little-endian; > + bus-width = <4>; > + status = "disabled"; > + }; > + > + esdhc1: mmc@2150000 { > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2150000 0x0 0x10000>; > + interrupts = <0 63 0x4>; /* Level high type */ > + clock-frequency = <0>; /* fixed up by bootloader */ > + clocks = <&clockgen 2 1>; > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + broken-cd; > + little-endian; > + bus-width = <4>; > + status = "disabled"; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1028a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 1.7.1
On Wed, May 15, 2019 at 04:49:25PM +0800, Yinbo Zhu wrote: > From: Ashish Kumar <Ashish.Kumar@nxp.com> > > This patch is to add esdhc node and enable SD UHS-I, > eMMC HS200 for ls1028ardb/ls1028aqds board. > > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com> > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com> > --- > Change in v3: > replace "esdhc@" with "mmc@" > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 ++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27 +++++++++++++++++++++ > 3 files changed, 48 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index 14c79f4..180e5d2 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -42,6 +42,14 @@ > status = "okay"; > }; > > +&esdhc { > + status = "okay"; > +}; > + > +&esdhc1 { > + status = "okay"; > +}; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > index f86b054..1bfaf42 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > @@ -30,6 +30,19 @@ > }; > }; > > +&esdhc { > + status = "okay"; We usually put 'status' at end of property list. > + sd-uhs-sdr104; > + sd-uhs-sdr50; > + sd-uhs-sdr25; > + sd-uhs-sdr12; > + }; Please follow the indent style of closing parentheses in the file. > + > +&esdhc1 { > + status = "okay"; > + mmc-hs200-1_8v; > + }; Ditto > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbc..462833c 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -274,6 +274,33 @@ > status = "disabled"; > }; > > + esdhc: mmc@2140000 { Please sort the nodes in unit-address. From what I see, it should go before device serial@21c0500. > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2140000 0x0 0x10000>; > + interrupts = <0 28 0x4>; /* Level high type */ Use IRQ_TYPE_LEVEL_HIGH, then you can drop the comment. Shawn > + clock-frequency = <0>; /* fixed up by bootloader */ > + clocks = <&clockgen 2 1>; > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + little-endian; > + bus-width = <4>; > + status = "disabled"; > + }; > + > + esdhc1: mmc@2150000 { > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2150000 0x0 0x10000>; > + interrupts = <0 63 0x4>; /* Level high type */ > + clock-frequency = <0>; /* fixed up by bootloader */ > + clocks = <&clockgen 2 1>; > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + broken-cd; > + little-endian; > + bus-width = <4>; > + status = "disabled"; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1028a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 1.7.1 >
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts index 14c79f4..180e5d2 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts @@ -42,6 +42,14 @@ status = "okay"; }; +&esdhc { + status = "okay"; +}; + +&esdhc1 { + status = "okay"; +}; + &i2c0 { status = "okay"; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts index f86b054..1bfaf42 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts @@ -30,6 +30,19 @@ }; }; +&esdhc { + status = "okay"; + sd-uhs-sdr104; + sd-uhs-sdr50; + sd-uhs-sdr25; + sd-uhs-sdr12; + }; + +&esdhc1 { + status = "okay"; + mmc-hs200-1_8v; + }; + &i2c0 { status = "okay"; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 2896bbc..462833c 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -274,6 +274,33 @@ status = "disabled"; }; + esdhc: mmc@2140000 { + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; + reg = <0x0 0x2140000 0x0 0x10000>; + interrupts = <0 28 0x4>; /* Level high type */ + clock-frequency = <0>; /* fixed up by bootloader */ + clocks = <&clockgen 2 1>; + voltage-ranges = <1800 1800 3300 3300>; + sdhci,auto-cmd12; + little-endian; + bus-width = <4>; + status = "disabled"; + }; + + esdhc1: mmc@2150000 { + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; + reg = <0x0 0x2150000 0x0 0x10000>; + interrupts = <0 63 0x4>; /* Level high type */ + clock-frequency = <0>; /* fixed up by bootloader */ + clocks = <&clockgen 2 1>; + voltage-ranges = <1800 1800 3300 3300>; + sdhci,auto-cmd12; + broken-cd; + little-endian; + bus-width = <4>; + status = "disabled"; + }; + sata: sata@3200000 { compatible = "fsl,ls1028a-ahci"; reg = <0x0 0x3200000 0x0 0x10000>,