Message ID | 20190516064304.24057-2-olof@lixom.net (mailing list archive) |
---|---|
State | Mainlined, archived |
Commit | 7a0c4c17089a8aff52f516f0f52002be52950aae |
Headers | show |
Series | ARM: SoC contents for 5.2 merge window | expand |
On Wed, May 15, 2019 at 11:43 PM Olof Johansson <olof@lixom.net> wrote: > > SoC updates, mostly refactorings and cleanups of old legacy platforms. > Major themes this release: Hmm. This brings in a new warning: drivers/clocksource/timer-ixp4xx.c:78:20: warning: ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function] because that drivers is enabled for build testing, but that function is only used under #ifdef CONFIG_ARM sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq); #endif It's not clear why that #ifdef is there. This driver only builds non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks that build test. I'm going to remove that #ifdef in my merge, because I do *not* want to see new warnings, and it doesn't seem to make any sense. Maybe that's the wrong resolution, please holler and let me know if you want something else. Linus
On Thu, May 16, 2019 at 5:34 PM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Wed, May 15, 2019 at 11:43 PM Olof Johansson <olof@lixom.net> wrote: > > > > SoC updates, mostly refactorings and cleanups of old legacy platforms. > > Major themes this release: > > Hmm. This brings in a new warning: > > drivers/clocksource/timer-ixp4xx.c:78:20: warning: > ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function] > > because that drivers is enabled for build testing, but that function > is only used under > > #ifdef CONFIG_ARM > sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq); > #endif > > It's not clear why that #ifdef is there. This driver only builds > non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks > that build test. > > I'm going to remove that #ifdef in my merge, because I do *not* want > to see new warnings, and it doesn't seem to make any sense. > > Maybe that's the wrong resolution, please holler and let me know if > you want something else. As far as I can tell, that is the best fix, thanks for the cleanup! Arnd
On 16/05/2019 17:33, Linus Torvalds wrote: > On Wed, May 15, 2019 at 11:43 PM Olof Johansson wrote: >> >> SoC updates, mostly refactorings and cleanups of old legacy platforms. >> Major themes this release: > > Hmm. This brings in a new warning: > > drivers/clocksource/timer-ixp4xx.c:78:20: warning: > ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function] > > because that drivers is enabled for build testing, but that function > is only used under > > #ifdef CONFIG_ARM > sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq); > #endif > > It's not clear why that #ifdef is there. This driver only builds > non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks > that build test. > > I'm going to remove that #ifdef in my merge, because I do *not* want > to see new warnings, and it doesn't seem to make any sense. > > Maybe that's the wrong resolution, please holler and let me know if > you want something else. Hello BDFL, Your email client did something strange by changing linux-arm-kernel@lists.infradead.org to "linux-alpha@vger.kernel.org" <linux-arm-kernel@lists.infradead.org> which is odd ;-) As for your actual remark, I note that Olof has an arm/late branch (which I assume he plans to submit in a few days?) which contains the change you mention: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/log/?h=arm/late https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=arm/late&id=5cb9de627e25421e2e2edaff6360c84d32cd3c02 Regards.
On Thu, May 16, 2019 at 9:00 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > Your email client did something strange by changing > > linux-arm-kernel@lists.infradead.org > to > "linux-alpha@vger.kernel.org" <linux-arm-kernel@lists.infradead.org> > > which is odd ;-) Heh. Indeed. What seems to have happened is that somebody long ago sent an email with a missing comma (so "linux-alpha@vger.kernel.org <linux-arm-kernel@lists.infradead.org>" - *intending* to send to both, but ending up with the linux-alpha list being the "name" for the linux-arm one). And then I replied to that email, and it got picked up as my automatic contact. So when I replied to linux-arm-kernel@lists.infradead.org, and it had no name, my automatic contacts helpfully filled in that bogus name for that list ;) I will fix. I note that because *you* had added the right name for the list, this reply didn't even try to use that bogus contact name. Linus
The pull request you sent on Wed, 15 May 2019 23:43:01 -0700:
> git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-soc
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/22c58fd70ca48a29505922b1563826593b08cc00
Thank you!
On Thu, May 16, 2019 at 8:53 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, May 16, 2019 at 5:34 PM Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > > > On Wed, May 15, 2019 at 11:43 PM Olof Johansson <olof@lixom.net> wrote: > > > > > > SoC updates, mostly refactorings and cleanups of old legacy platforms. > > > Major themes this release: > > > > Hmm. This brings in a new warning: > > > > drivers/clocksource/timer-ixp4xx.c:78:20: warning: > > ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function] > > > > because that drivers is enabled for build testing, but that function > > is only used under > > > > #ifdef CONFIG_ARM > > sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq); > > #endif > > > > It's not clear why that #ifdef is there. This driver only builds > > non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks > > that build test. > > > > I'm going to remove that #ifdef in my merge, because I do *not* want > > to see new warnings, and it doesn't seem to make any sense. > > > > Maybe that's the wrong resolution, please holler and let me know if > > you want something else. > > As far as I can tell, that is the best fix, thanks for the cleanup! Yeah, this was entirely on me -- it was found and fixed on linux-next, and Linus Walleij sent patches. However, as I was staging these pull requests, I applied them to a branch of fixes that I'm collecting for later this week instead of on top of the one I was sending. Thanks for fixing it up. -Olof
On Thu, May 16, 2019 at 7:10 PM Olof Johansson <olof@lixom.net> wrote: > On Thu, May 16, 2019 at 8:53 AM Arnd Bergmann <arnd@arndb.de> wrote: > > > I'm going to remove that #ifdef in my merge, because I do *not* want > > > to see new warnings, and it doesn't seem to make any sense. > > > > > > Maybe that's the wrong resolution, please holler and let me know if > > > you want something else. > > > > As far as I can tell, that is the best fix, thanks for the cleanup! > > Yeah, this was entirely on me -- it was found and fixed on linux-next, > and Linus Walleij sent patches. However, as I was staging these pull > requests, I applied them to a branch of fixes that I'm collecting for > later this week instead of on top of the one I was sending. > > Thanks for fixing it up. Oh well Linus wrote the bug and then Linus fixed it and then Linus fixed it. What is good to know is that no matter which Linus you use, you will always get the right fix. Yours, Linus Walleij