diff mbox series

arm64: dts: fsl: ls1046: Modify the qspi flash frequency

Message ID 20190521150336.8409-1-pankaj.bansal@nxp.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: fsl: ls1046: Modify the qspi flash frequency | expand

Commit Message

Pankaj Bansal May 21, 2019, 9:40 a.m. UTC
The qspi flash in ls1046a based QDS and RDB boards can operate
at 50MHz frequency.
Therefore, update the maximum supported freq in their respective
dts files.

Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

Comments

Shawn Guo May 23, 2019, 12:48 p.m. UTC | #1
On Tue, May 21, 2019 at 09:40:09AM +0000, Pankaj Bansal wrote:
> The qspi flash in ls1046a based QDS and RDB boards can operate
> at 50MHz frequency.
> Therefore, update the maximum supported freq in their respective
> dts files.
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>

Do not use base64 encoding for patch posting.

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 5 +++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index eec62c63dafe..e441dbfbfb81 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -3,7 +3,7 @@
>   * Device Tree Include file for Freescale Layerscape-1046A family SoC.
>   *
>   * Copyright 2016 Freescale Semiconductor, Inc.
> - * Copyright 2018 NXP
> + * Copyright 2018-2019 NXP
>   *
>   * Shaohui Xie <Shaohui.Xie@nxp.com>
>   */
> @@ -169,7 +169,7 @@
>  		compatible = "spansion,m25p80";
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -		spi-max-frequency = <20000000>;
> +		spi-max-frequency = <50000000>;
>  		spi-rx-bus-width = <4>;
>  		spi-tx-bus-width = <4>;
>  		reg = <0>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 6a6514d0e5a9..6f5411d09bb9 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -3,6 +3,7 @@
>   * Device Tree Include file for Freescale Layerscape-1046A family SoC.
>   *
>   * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2019 NXP
>   *
>   * Mingkai Hu <mingkai.hu@nxp.com>
>   */
> @@ -105,7 +106,7 @@
>  		compatible = "spansion,m25p80";
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -		spi-max-frequency = <20000000>;
> +		spi-max-frequency = <50000000>;
>  		spi-rx-bus-width = <4>;
>  		spi-tx-bus-width = <4>;
>  		reg = <0>;
> @@ -115,7 +116,7 @@
>  		compatible = "spansion,m25p80";
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -		spi-max-frequency = <20000000>;
> +		spi-max-frequency = <50000000>;
>  		spi-rx-bus-width = <4>;
>  		spi-tx-bus-width = <4>;
>  		reg = <1>;
> -- 
> 2.17.1
>
Pankaj Bansal May 27, 2019, 6:12 a.m. UTC | #2
HI Shawn,

> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Thursday, 23 May, 2019 06:18 PM
> To: Pankaj Bansal <pankaj.bansal@nxp.com>
> Cc: Leo Li <leoyang.li@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>; Rajesh
> Bhagat <rajesh.bhagat@nxp.com>; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH] arm64: dts: fsl: ls1046: Modify the qspi flash frequency
> 
> On Tue, May 21, 2019 at 09:40:09AM +0000, Pankaj Bansal wrote:
> > The qspi flash in ls1046a based QDS and RDB boards can operate at
> > 50MHz frequency.
> > Therefore, update the maximum supported freq in their respective dts
> > files.
> >
> > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> 
> Do not use base64 encoding for patch posting.

I did not understand this comment? Do you want me to change something in patch?
I had run checkpatch script on the patch before sending and it did not report any waning or error.
Can this patch not be merged in current tree ?

> 
> Shawn
> 
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++--
> > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 5 +++--
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> > index eec62c63dafe..e441dbfbfb81 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> > @@ -3,7 +3,7 @@
> >   * Device Tree Include file for Freescale Layerscape-1046A family SoC.
> >   *
> >   * Copyright 2016 Freescale Semiconductor, Inc.
> > - * Copyright 2018 NXP
> > + * Copyright 2018-2019 NXP
> >   *
> >   * Shaohui Xie <Shaohui.Xie@nxp.com>
> >   */
> > @@ -169,7 +169,7 @@
> >  		compatible = "spansion,m25p80";
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -		spi-max-frequency = <20000000>;
> > +		spi-max-frequency = <50000000>;
> >  		spi-rx-bus-width = <4>;
> >  		spi-tx-bus-width = <4>;
> >  		reg = <0>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> > index 6a6514d0e5a9..6f5411d09bb9 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> > @@ -3,6 +3,7 @@
> >   * Device Tree Include file for Freescale Layerscape-1046A family SoC.
> >   *
> >   * Copyright 2016 Freescale Semiconductor, Inc.
> > + * Copyright 2019 NXP
> >   *
> >   * Mingkai Hu <mingkai.hu@nxp.com>
> >   */
> > @@ -105,7 +106,7 @@
> >  		compatible = "spansion,m25p80";
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -		spi-max-frequency = <20000000>;
> > +		spi-max-frequency = <50000000>;
> >  		spi-rx-bus-width = <4>;
> >  		spi-tx-bus-width = <4>;
> >  		reg = <0>;
> > @@ -115,7 +116,7 @@
> >  		compatible = "spansion,m25p80";
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -		spi-max-frequency = <20000000>;
> > +		spi-max-frequency = <50000000>;
> >  		spi-rx-bus-width = <4>;
> >  		spi-tx-bus-width = <4>;
> >  		reg = <1>;
> > --
> > 2.17.1
> >
Shawn Guo May 31, 2019, 7:41 a.m. UTC | #3
On Mon, May 27, 2019 at 06:12:28AM +0000, Pankaj Bansal wrote:
> HI Shawn,
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Thursday, 23 May, 2019 06:18 PM
> > To: Pankaj Bansal <pankaj.bansal@nxp.com>
> > Cc: Leo Li <leoyang.li@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>; Rajesh
> > Bhagat <rajesh.bhagat@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org
> > Subject: Re: [PATCH] arm64: dts: fsl: ls1046: Modify the qspi flash frequency
> > 
> > On Tue, May 21, 2019 at 09:40:09AM +0000, Pankaj Bansal wrote:
> > > The qspi flash in ls1046a based QDS and RDB boards can operate at
> > > 50MHz frequency.
> > > Therefore, update the maximum supported freq in their respective dts
> > > files.
> > >
> > > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> > 
> > Do not use base64 encoding for patch posting.
> 
> I did not understand this comment? Do you want me to change something in patch?
> I had run checkpatch script on the patch before sending and it did not report any waning or error.
> Can this patch not be merged in current tree ?

You mail server is using a content-transfer-encoding that makes patch
applying very difficult.  Talk to NXP colleague Anson Huang
<Anson.Huang@nxp.com> to find out how to fix it.

https://patchwork.kernel.org/patch/10944169/#22656941

Shawn
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index eec62c63dafe..e441dbfbfb81 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -3,7 +3,7 @@ 
  * Device Tree Include file for Freescale Layerscape-1046A family SoC.
  *
  * Copyright 2016 Freescale Semiconductor, Inc.
- * Copyright 2018 NXP
+ * Copyright 2018-2019 NXP
  *
  * Shaohui Xie <Shaohui.Xie@nxp.com>
  */
@@ -169,7 +169,7 @@ 
 		compatible = "spansion,m25p80";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		spi-max-frequency = <20000000>;
+		spi-max-frequency = <50000000>;
 		spi-rx-bus-width = <4>;
 		spi-tx-bus-width = <4>;
 		reg = <0>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
index 6a6514d0e5a9..6f5411d09bb9 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
@@ -3,6 +3,7 @@ 
  * Device Tree Include file for Freescale Layerscape-1046A family SoC.
  *
  * Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2019 NXP
  *
  * Mingkai Hu <mingkai.hu@nxp.com>
  */
@@ -105,7 +106,7 @@ 
 		compatible = "spansion,m25p80";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		spi-max-frequency = <20000000>;
+		spi-max-frequency = <50000000>;
 		spi-rx-bus-width = <4>;
 		spi-tx-bus-width = <4>;
 		reg = <0>;
@@ -115,7 +116,7 @@ 
 		compatible = "spansion,m25p80";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		spi-max-frequency = <20000000>;
+		spi-max-frequency = <50000000>;
 		spi-rx-bus-width = <4>;
 		spi-tx-bus-width = <4>;
 		reg = <1>;