| Message ID | 20190525180923.6105-5-peron.clem@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allwiner A64/H6 IR support | expand |
On Sat, May 25, 2019 at 08:09:17PM +0200, Clément Péron wrote: > There is some minor differences between A31 and A64 driver. > > But A31 IR driver is compatible with A64. > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > Documentation/devicetree/bindings/media/sunxi-ir.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/sunxi-ir.txt b/Documentation/devicetree/bindings/media/sunxi-ir.txt > index 53e88ebb53fe..da5aeba843de 100644 > --- a/Documentation/devicetree/bindings/media/sunxi-ir.txt > +++ b/Documentation/devicetree/bindings/media/sunxi-ir.txt > @@ -5,6 +5,7 @@ Required properties: > "allwinner,sun4i-a10-ir" > "allwinner,sun5i-a13-ir" > "allwinner,sun6i-a31-ir" > + "allwinner,sun50i-a64-ir", "allwinner,sun6i-a31-ir" I guess resets is mandatory for the A31 onwards too, right? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Maxime, On Sun, 26 May 2019 at 21:04, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Sat, May 25, 2019 at 08:09:17PM +0200, Clément Péron wrote: > > There is some minor differences between A31 and A64 driver. > > > > But A31 IR driver is compatible with A64. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > Documentation/devicetree/bindings/media/sunxi-ir.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/sunxi-ir.txt b/Documentation/devicetree/bindings/media/sunxi-ir.txt > > index 53e88ebb53fe..da5aeba843de 100644 > > --- a/Documentation/devicetree/bindings/media/sunxi-ir.txt > > +++ b/Documentation/devicetree/bindings/media/sunxi-ir.txt > > @@ -5,6 +5,7 @@ Required properties: > > "allwinner,sun4i-a10-ir" > > "allwinner,sun5i-a13-ir" > > "allwinner,sun6i-a31-ir" > > + "allwinner,sun50i-a64-ir", "allwinner,sun6i-a31-ir" > > I guess resets is mandatory for the A31 onwards too, right? Indeed, I will add this information in the device-tree bindings. Ideally, we should also introduce a quirks with a "has_reset" property. Thanks for your review, Clément > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/Documentation/devicetree/bindings/media/sunxi-ir.txt b/Documentation/devicetree/bindings/media/sunxi-ir.txt index 53e88ebb53fe..da5aeba843de 100644 --- a/Documentation/devicetree/bindings/media/sunxi-ir.txt +++ b/Documentation/devicetree/bindings/media/sunxi-ir.txt @@ -5,6 +5,7 @@ Required properties: "allwinner,sun4i-a10-ir" "allwinner,sun5i-a13-ir" "allwinner,sun6i-a31-ir" + "allwinner,sun50i-a64-ir", "allwinner,sun6i-a31-ir" - clocks : list of clock specifiers, corresponding to entries in clock-names property; - clock-names : should contain "apb" and "ir" entries;
There is some minor differences between A31 and A64 driver. But A31 IR driver is compatible with A64. Signed-off-by: Clément Péron <peron.clem@gmail.com> --- Documentation/devicetree/bindings/media/sunxi-ir.txt | 1 + 1 file changed, 1 insertion(+)