diff mbox series

[v3,1/3] dt-bindings: arm: nxp: Add device tree binding for ls1046a-frwy board

Message ID 20190527123404.30858-2-pramod.kumar_1@nxp.com (mailing list archive)
State Superseded
Headers show
Series arm64: dts: nxp: add ls1046a frwy board support | expand

Commit Message

Pramod Kumar May 27, 2019, 12:32 p.m. UTC
Add "fsl,ls1046a-frwy" bindings for ls1046afrwy board based on ls1046a SoC

Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo June 5, 2019, 6:34 a.m. UTC | #1
On Mon, May 27, 2019 at 12:32:09PM +0000, Pramod Kumar wrote:
> Add "fsl,ls1046a-frwy" bindings for ls1046afrwy board based on ls1046a SoC
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

I cannot apply patch from message using 'Content-Transfer-Encoding: base64'.

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 407138ebc0d0..09ff1999ce96 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -241,6 +241,7 @@ properties:
>            - enum:
>                - fsl,ls1046a-qds
>                - fsl,ls1046a-rdb
> +              - fsl,ls1046a-frwy

It might be better to keep the list alphabetically sorted.

Shawn

>            - const: fsl,ls1046a
>  
>        - description: LS1088A based Boards
> -- 
> 2.17.1
>
Dong Aisheng June 5, 2019, 7 a.m. UTC | #2
Hi Pramod,

> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Wednesday, June 5, 2019 2:35 PM
> Subject: Re: [PATCH v3 1/3] dt-bindings: arm: nxp: Add device tree binding for
> ls1046a-frwy board
> 
> On Mon, May 27, 2019 at 12:32:09PM +0000, Pramod Kumar wrote:
> > Add "fsl,ls1046a-frwy" bindings for ls1046afrwy board based on ls1046a SoC
> >
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> 
> I cannot apply patch from message using 'Content-Transfer-Encoding: base64'.
> 

Which server are you using? Is it in the whitelist for using the specific SMTP?
I remember DN server does not have this issue. Maybe using the wrong one?

Regards
Dong Aisheng

> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 407138ebc0d0..09ff1999ce96 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -241,6 +241,7 @@ properties:
> >            - enum:
> >                - fsl,ls1046a-qds
> >                - fsl,ls1046a-rdb
> > +              - fsl,ls1046a-frwy
> 
> It might be better to keep the list alphabetically sorted.
> 
> Shawn
> 
> >            - const: fsl,ls1046a
> >
> >        - description: LS1088A based Boards
> > --
> > 2.17.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 407138ebc0d0..09ff1999ce96 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -241,6 +241,7 @@  properties:
           - enum:
               - fsl,ls1046a-qds
               - fsl,ls1046a-rdb
+              - fsl,ls1046a-frwy
           - const: fsl,ls1046a
 
       - description: LS1088A based Boards