| Message ID | 20190528124406.29730-1-angus@akkea.ca (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: fsl: imx8mq: enable the svns power key | expand |
Hi Angus, Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie (Purism): > Add the snvs power key. > > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 45d10d8efd14..5f93fd9662ae 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -8,6 +8,7 @@ > #include <dt-bindings/power/imx8mq-power.h> > #include <dt-bindings/reset/imx8mq-reset.h> > #include <dt-bindings/gpio/gpio.h> > +#include "dt-bindings/input/input.h" > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/thermal/thermal.h> > #include "imx8mq-pinfunc.h" > @@ -463,6 +464,14 @@ > > interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>; > > }; > + > > + snvs_pwrkey: snvs-powerkey { > > + compatible = "fsl,sec-v4.0-pwrkey"; > > + regmap = <&snvs>; > > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > > + linux,keycode = <KEY_POWER>; > + wakeup-source; Not all i.MX8MQ systems will have this functionality wired up at the board level, so this node needs to be disabled by default. The existing i.MX6 and i.MX7 DTs seem to get this wrong. Regards, Lucas > + }; > > }; > > > > clk: clock-controller@30380000 {
Hi Lucas, On 2019-05-28 05:51, Lucas Stach wrote: > Hi Angus, > > Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie > (Purism): >> Add the snvs power key. >> >> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> >> --- >> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> index 45d10d8efd14..5f93fd9662ae 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> @@ -8,6 +8,7 @@ >> #include <dt-bindings/power/imx8mq-power.h> >> #include <dt-bindings/reset/imx8mq-reset.h> >> #include <dt-bindings/gpio/gpio.h> >> +#include "dt-bindings/input/input.h" >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> #include <dt-bindings/thermal/thermal.h> >> #include "imx8mq-pinfunc.h" >> @@ -463,6 +464,14 @@ >> > interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, >> > <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>; >> > }; >> + >> > + snvs_pwrkey: snvs-powerkey { >> > + compatible = "fsl,sec-v4.0-pwrkey"; >> > + regmap = <&snvs>; >> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; >> > + linux,keycode = <KEY_POWER>; >> + wakeup-source; > > Not all i.MX8MQ systems will have this functionality wired up at the > board level, so this node needs to be disabled by default. The existing > i.MX6 and i.MX7 DTs seem to get this wrong. > Ok I'll fix that for the next rev. Thanks Angus > Regards, > Lucas > >> + }; >> > }; >> >> > > clk: clock-controller@30380000 {
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 45d10d8efd14..5f93fd9662ae 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -8,6 +8,7 @@ #include <dt-bindings/power/imx8mq-power.h> #include <dt-bindings/reset/imx8mq-reset.h> #include <dt-bindings/gpio/gpio.h> +#include "dt-bindings/input/input.h" #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/thermal/thermal.h> #include "imx8mq-pinfunc.h" @@ -463,6 +464,14 @@ interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>; }; + + snvs_pwrkey: snvs-powerkey { + compatible = "fsl,sec-v4.0-pwrkey"; + regmap = <&snvs>; + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; + linux,keycode = <KEY_POWER>; + wakeup-source; + }; }; clk: clock-controller@30380000 {
Add the snvs power key. Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)