| Message ID | 20190613161656.20765-2-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | arm64/sve: First steps towards optimizing syscalls | expand |
Hmmm... I just realized that I missed some comments from Marc Rutland on this patch and the next one. I will address them in the next version. Sorry for the inconvenience. Cheers, On 13/06/2019 17:16, Julien Grall wrote: > TIF_SVE is cleared by fpsimd_restore_current_state() not > task_fpsimd_load(). Update the documentation of do_sve_acc to reflect > this behavior. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > > --- > Changes in v2: > - Fix typo in the commit message > --- > arch/arm64/kernel/fpsimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index a38bf74bcca8..92f418e4f989 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -853,7 +853,7 @@ void fpsimd_release_task(struct task_struct *dead_task) > * the SVE access trap will be disabled the next time this task > * reaches ret_to_user. > * > - * TIF_SVE should be clear on entry: otherwise, task_fpsimd_load() > + * TIF_SVE should be clear on entry: otherwise, fpsimd_restore_current_state() > * would have disabled the SVE access trap for userspace during > * ret_to_user, making an SVE access trap impossible in that case. > */ >
On Thu, Jun 13, 2019 at 05:16:49PM +0100, Julien Grall wrote: > TIF_SVE is cleared by fpsimd_restore_current_state() not > task_fpsimd_load(). Update the documentation of do_sve_acc to reflect > this behavior. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > > --- > Changes in v2: > - Fix typo in the commit message > --- > arch/arm64/kernel/fpsimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index a38bf74bcca8..92f418e4f989 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -853,7 +853,7 @@ void fpsimd_release_task(struct task_struct *dead_task) > * the SVE access trap will be disabled the next time this task > * reaches ret_to_user. > * > - * TIF_SVE should be clear on entry: otherwise, task_fpsimd_load() > + * TIF_SVE should be clear on entry: otherwise, fpsimd_restore_current_state() > * would have disabled the SVE access trap for userspace during > * ret_to_user, making an SVE access trap impossible in that case. > */ Good spot, thanks! Modulo any outstanding comments from Mark, Reviewed-by: Dave Martin <Dave.Martin@arm.com> Cheers ---Dave
diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index a38bf74bcca8..92f418e4f989 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -853,7 +853,7 @@ void fpsimd_release_task(struct task_struct *dead_task) * the SVE access trap will be disabled the next time this task * reaches ret_to_user. * - * TIF_SVE should be clear on entry: otherwise, task_fpsimd_load() + * TIF_SVE should be clear on entry: otherwise, fpsimd_restore_current_state() * would have disabled the SVE access trap for userspace during * ret_to_user, making an SVE access trap impossible in that case. */
TIF_SVE is cleared by fpsimd_restore_current_state() not task_fpsimd_load(). Update the documentation of do_sve_acc to reflect this behavior. Signed-off-by: Julien Grall <julien.grall@arm.com> --- Changes in v2: - Fix typo in the commit message --- arch/arm64/kernel/fpsimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)