From patchwork Wed Jun 19 12:56:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11004105 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2196E1395 for ; Wed, 19 Jun 2019 12:56:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1069B28999 for ; Wed, 19 Jun 2019 12:56:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0217E289B5; Wed, 19 Jun 2019 12:56:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE29028999 for ; Wed, 19 Jun 2019 12:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=17+HzL8Y4DmbIVKs0WiZ69XGHqmihvPdm7jrQp4yu3g=; b=n4hgVGy0PRU9Ie +ZsFvMo++w+0N7dxdI6hvvqcSwunM8Y81z2Kkr6KLnEABDU1h2VQ1m334lSiy6YQ7tMXh05mV68RU NIZzbxzI7UNmlYh0jAMRwPRZ6towtxH78UGdkZK8FhPKSd98+EMeSLlwAOBEyiib8y2YQVvVGaEcc DczsqYkw4ZhGSXJ1we/HJ/mLOuMA26A8j8+sfnUVVCQgZWG7CChVBVE5J7Zz+dArohKsuxC6C5Qia sHJP72wxrUKusUIUgQlmJ4SexNk48WSOgvVHNjAwnmERrrLToQuJjgqTFhJeddtKidiPB9Jysazmw dGV1qwGC5p1UKfkwLJHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hda94-0006aG-9S; Wed, 19 Jun 2019 12:56:58 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hda91-0006Zn-MP for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 12:56:57 +0000 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1Md6dH-1iCdyW161r-00aBCA; Wed, 19 Jun 2019 14:56:39 +0200 From: Arnd Bergmann To: Joel Stanley Subject: [PATCH] soc: aspeed: fix probe error handling Date: Wed, 19 Jun 2019 14:56:23 +0200 Message-Id: <20190619125636.1109665-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:ZJwSOzQMuPpHsrU/+qvC0BE/4HBT6tcQ0i6nWWwdFMZI7Lp37LT EhDuHwiX9TgKYWtK3bytwlf9alSchNSd3HIu3+i2ShJqPpZF0IycKFhDZRLr5nSzcurUU8s TTlggu2/kKjAzmi0JMsgLMKJmUrck9PseSduRgPAZEBfkRhQNKngF+cstswdqnsCwYfUOtC DYfjeGhgOkWZQRKdeV1CA== X-UI-Out-Filterresults: notjunk:1;V03:K0:LGDpA5YzoUY=:XTDjw9epM4xTzibkdByj5K GhIoK1yF82OWjpMeOzQgnmeVnkx98/kU1pZTERJCdJi9xsYO1rzx9v4BHyw5hNVXMy/hoCMmg R8ZUvFbo6ALJY8qcu7O5sAM029mTaKymbN4tbNjRxpFH09r/9tst6rkT/62mTG1X0CaIHbqI3 3NDJMvWo9oGLsuysv9X4bzP9Ohdb1IPgcYF81bZjPJ5Jlvk7UR9kul0VZwkrWf0PoT+2fe4aH MJlMnX3rtqs4jmF0+rRuDvyuBggJN48PVLtQxln1U5D2RIpZ6Jab4MFQDQV7qEsJQDgreu4DZ yYsPkVE4zRFFgpoaHazeuL0hCbVHIuMe3osHNpKwDMmQV8PosE9SLcSWhVhM8PB7DqE1urHWI SeUA6A9vR3ajuhrYaJ9R/ggQqrQT/MwGZrOgQeoey0A8bRDrGMtRF9sJWkJzVs6lR+LBZ/Qd4 Fh42eJZWNZYEmS3P1g8BeedER3edpIzzMXbxCpf/UMTBgviowSsQJs7shQ/ziyd09yYR/tfun NuC+QPCKou2F9BahTgQTYa+LcqCyJPLax11e2Y4nfwrpWDSSbqzbA2bqqatWpKGYyvZOG0pJM YFfWa4oPOTxWvC+bVAjlmbmiRPXRbMGMKEBSUKU+GMW/9c5sWM81NlPtEdifftrsH1Wuyv9bv lJREE0KyXnqutSAdXz7DjuUmD/K9lGRQXfkts2x5y1NJ0jP3hWiVyFq05qQ/fhd2egAL4DpIm RZkS4jUol5xwipOEO5zrS9SItLbZ3JG+d4LH5g== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_055656_044648_E074A529 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Patrick Venture , linux-kernel@vger.kernel.org, Vijay Khemka , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP gcc warns that a mising "flash" phandle node leads to undefined behavior later: drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized] The device cannot work without this node, so just error out here. Signed-off-by: Arnd Bergmann --- drivers/soc/aspeed/aspeed-lpc-ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-lpc-ctrl.c index 239520bb207e..81109d22af6a 100644 --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c @@ -212,6 +212,7 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) node = of_parse_phandle(dev->of_node, "flash", 0); if (!node) { dev_dbg(dev, "Didn't find host pnor flash node\n"); + return -ENXIO; } else { rc = of_address_to_resource(node, 1, &resm); of_node_put(node);