| Message ID | 20190627173536.2457-1-huangfq.daxian@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 28-06-19, 01:35, Fuqian Huang wrote: > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. Please point to the exact commit and not the merge commit. Hint use git blame on that file... > > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> > --- > drivers/dma/imx-sdma.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 99d9f431ae2c..54d86359bdf8 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma) > sdma->context_phys = ccb_phys + > MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control); > > - /* Zero-out the CCB structures array just allocated */ > - memset(sdma->channel_control, 0, > - MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control)); > - > /* disable all channels */ > for (i = 0; i < sdma->drvdata->num_events; i++) > writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i)); > -- > 2.11.0
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 99d9f431ae2c..54d86359bdf8 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma) sdma->context_phys = ccb_phys + MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control); - /* Zero-out the CCB structures array just allocated */ - memset(sdma->channel_control, 0, - MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control)); - /* disable all channels */ for (i = 0; i < sdma->drvdata->num_events; i++) writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i));
In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> --- drivers/dma/imx-sdma.c | 4 ---- 1 file changed, 4 deletions(-)