| Message ID | 20190704084617.3602-5-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Platform drivers, provide a way to add sysfs groups easily | expand |
On Thu, Jul 04, 2019 at 10:46:10AM +0200, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a sysfs group of attributes. > > Cc: Sudeep Holla <sudeep.holla@arm.com> Assuming you plan to take this series as a whole, Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
On Thu, Jul 04, 2019 at 10:10:26AM +0100, Sudeep Holla wrote: > On Thu, Jul 04, 2019 at 10:46:10AM +0200, Greg Kroah-Hartman wrote: > > Platform drivers now have the option to have the platform core create > > and remove any needed sysfs attribute files. So take advantage of that > > and do not register "by hand" a sysfs group of attributes. > > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > Assuming you plan to take this series as a whole, > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> Thanks, there will be one more series, but ideally we can take the whole thing as-is. greg k-h
diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 725164b83242..2774ec886d60 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -1011,10 +1011,6 @@ static int scpi_probe(struct platform_device *pdev) scpi_info->firmware_version)); scpi_info->scpi_ops = &scpi_ops; - ret = devm_device_add_groups(dev, versions_groups); - if (ret) - dev_err(dev, "unable to create sysfs version group\n"); - return devm_of_platform_populate(dev); } @@ -1033,6 +1029,7 @@ static struct platform_driver scpi_driver = { }, .probe = scpi_probe, .remove = scpi_remove, + .dev_groups = versions_groups, }; module_platform_driver(scpi_driver);
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a sysfs group of attributes. Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/firmware/arm_scpi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)